Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(frontend)[AGE-1462]: Global configuration setup for swr library #2361

Merged
merged 9 commits into from
Dec 18, 2024
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {isDemo} from "@/lib/helpers/utils"
import {Button, Col, Dropdown, MenuProps, Modal, ModalProps, Row, Spin, message} from "antd"
import {getErrorMessage} from "@/lib/helpers/errorHandler"
import {EvaluationType} from "@/lib/enums"
import {PERMISSION_ERR_MSG} from "@/lib/helpers/axiosConfig"
import {PERMISSION_ERR_MSG} from "@/lib/api/assets/axiosConfig"
import {getAllVariantParameters} from "@/lib/helpers/variantHelper"
import {useRouter} from "next/router"
import {useAppTheme} from "../Layout/ThemeContextProvider"
Expand Down
7 changes: 2 additions & 5 deletions agenta-web/src/contexts/app.context.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,9 @@ const useApps = () => {
const isMockProjectId = projectId === DEFAULT_UUID

const {selectedOrg, loading} = useOrgData()
const shouldFetch = !!user && (!isDemo() || !!selectedOrg?.id)
const {data, error, isLoading, mutate} = useSWR(
!!user
? `${getAgentaApiUrl()}/api/apps?` +
(!isMockProjectId ? `project_id=${projectId}&` : "")
: null,
!!user ? (isDemo() ? (selectedOrg?.id ? axiosFetcher : () => {}) : axiosFetcher) : null,
shouldFetch ? `/api/apps?` + (!isMockProjectId ? `project_id=${projectId}&` : "") : null,
{
shouldRetryOnError: false,
},
Expand Down
19 changes: 19 additions & 0 deletions agenta-web/src/lib/api/SWRConfig.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import {SWRConfig, type SWRConfiguration} from "swr"
import axios from "@/lib/api/assets/axiosConfig"

const config: SWRConfiguration = {
fetcher: (url: string) => axios.get(url).then((res) => res.data),
}

const AgSWRConfig = ({
children,
config: passedConfig = {},
}: {
children: React.ReactNode
config?: Partial<SWRConfiguration>
}) => {
const mergedConfig = {...config, ...passedConfig}
return <SWRConfig value={mergedConfig}>{children}</SWRConfig>
}

export default AgSWRConfig
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import axiosApi from "axios"
import {getErrorMessage, globalErrorHandler} from "./errorHandler"
import {getErrorMessage, globalErrorHandler} from "../../helpers/errorHandler"
import {signOut} from "supertokens-auth-react/recipe/session"
import router from "next/router"
import {getAgentaApiUrl} from "./utils"
import {getAgentaApiUrl} from "../../helpers/utils"
import isObject from "lodash/isObject"
import AlertPopup from "@/components/AlertPopup/AlertPopup"

Expand Down
2 changes: 1 addition & 1 deletion agenta-web/src/lib/hooks/useVariant.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {useState, useEffect, useRef} from "react"
import {Variant, Parameter} from "@/lib/Types"
import {getAllVariantParameters, updateInputParams} from "@/lib/helpers/variantHelper"
import {PERMISSION_ERR_MSG} from "../helpers/axiosConfig"
import {PERMISSION_ERR_MSG} from "../api/assets/axiosConfig"
import {createNewVariant, fetchVariantLogs, updateVariantParams} from "@/services/playground/api"

/**
Expand Down
39 changes: 21 additions & 18 deletions agenta-web/src/pages/_app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import ProjectContextProvider from "@/contexts/project.context"
import "ag-grid-community/styles/ag-grid.css"
import "ag-grid-community/styles/ag-theme-alpine.css"
import {Inter} from "next/font/google"
import AgSWRConfig from "@/lib/api/SWRConfig"

const NoMobilePageWrapper = dynamicComponent("NoMobilePageWrapper/NoMobilePageWrapper")
const CustomPosthogProvider = dynamic(() => import("@/lib/helpers/analytics/AgPosthogProvider"))
Expand All @@ -29,24 +30,26 @@ export default function App({Component, pageProps}: AppProps) {
<link rel="shortcut icon" href="/assets/favicon.ico" />
</Head>
<main className={`${inter.variable} font-sans`}>
<CustomPosthogProvider
config={{
persistence: "localStorage+cookie",
}}
>
<ThemeContextProvider>
<ProfileContextProvider>
<ProjectContextProvider>
<AppContextProvider>
<Layout>
<Component {...pageProps} />
<NoMobilePageWrapper />
</Layout>
</AppContextProvider>
</ProjectContextProvider>
</ProfileContextProvider>
</ThemeContextProvider>
</CustomPosthogProvider>
<AgSWRConfig>
<CustomPosthogProvider
config={{
persistence: "localStorage+cookie",
}}
>
<ThemeContextProvider>
<ProfileContextProvider>
<ProjectContextProvider>
<AppContextProvider>
<Layout>
<Component {...pageProps} />
<NoMobilePageWrapper />
</Layout>
</AppContextProvider>
</ProjectContextProvider>
</ProfileContextProvider>
</ThemeContextProvider>
</CustomPosthogProvider>
</AgSWRConfig>
</main>
</>
)
Expand Down
2 changes: 1 addition & 1 deletion agenta-web/src/services/api.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {getCurrentProject} from "@/contexts/project.context"
import axios from "@/lib//helpers/axiosConfig"
import axios from "@/lib/api/assets/axiosConfig"
import Session from "supertokens-auth-react/recipe/session"
import {formatDay} from "@/lib/helpers/dateTimeHelper"
import {
Expand Down
2 changes: 1 addition & 1 deletion agenta-web/src/services/app-selector/api/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {getCurrentProject} from "@/contexts/project.context"
import {AppTemplate} from "@/lib/Types"
import axios from "@/lib/helpers/axiosConfig"
import axios from "@/lib/api/assets/axiosConfig"
import {dynamicContext} from "@/lib/helpers/dynamic"
import {LlmProvider} from "@/lib/helpers/llmProviders"
import {getAgentaApiUrl} from "@/lib/helpers/utils"
Expand Down
2 changes: 1 addition & 1 deletion agenta-web/src/services/deployment/api/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {getCurrentProject} from "@/contexts/project.context"
import {Environment} from "@/lib/Types"
import axios from "@/lib/helpers/axiosConfig"
import axios from "@/lib/api/assets/axiosConfig"
import {getAgentaApiUrl} from "@/lib/helpers/utils"

//Prefix convention:
Expand Down
2 changes: 1 addition & 1 deletion agenta-web/src/services/evaluations/api/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import axios from "@/lib//helpers/axiosConfig"
import axios from "@/lib/api/assets/axiosConfig"
import {
ComparisonResultRow,
Evaluator,
Expand Down
2 changes: 1 addition & 1 deletion agenta-web/src/services/human-evaluations/api/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import axios from "@/lib//helpers/axiosConfig"
import axios from "@/lib/api/assets/axiosConfig"
import {
EvaluationResponseType,
Evaluation,
Expand Down
2 changes: 1 addition & 1 deletion agenta-web/src/services/observability/core/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {getAgentaApiUrl} from "@/lib/helpers/utils"
import {_AgentaRootsResponse} from "../types"
import axios from "@/lib/helpers/axiosConfig"
import axios from "@/lib/api/assets/axiosConfig"
import {getCurrentProject} from "@/contexts/project.context"

//Prefix convention:
Expand Down
2 changes: 1 addition & 1 deletion agenta-web/src/services/playground/api/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {getCurrentProject} from "@/contexts/project.context"
import {Parameter} from "@/lib/Types"
import axios from "@/lib/helpers/axiosConfig"
import axios from "@/lib/api/assets/axiosConfig"
import {getAgentaApiUrl} from "@/lib/helpers/utils"

//Prefix convention:
Expand Down
2 changes: 1 addition & 1 deletion agenta-web/src/services/project/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import axios from "@/lib/helpers/axiosConfig"
import axios from "@/lib/api/assets/axiosConfig"
import {getAgentaApiUrl} from "@/lib/helpers/utils"
import {ProjectsResponse} from "./types"

Expand Down
11 changes: 5 additions & 6 deletions agenta-web/src/services/testsets/api/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import useSWR from "swr"
import axios from "@/lib/helpers/axiosConfig"
import axios from "@/lib/api/assets/axiosConfig"
import {getAgentaApiUrl} from "@/lib/helpers/utils"
import {axiosFetcher} from "@/services/api"
import {getCurrentProject} from "@/contexts/project.context"
Expand All @@ -14,11 +14,10 @@ import {getCurrentProject} from "@/contexts/project.context"
export const useLoadTestsetsList = () => {
const {projectId} = getCurrentProject()

const {data, error, mutate, isLoading} = useSWR(
`${getAgentaApiUrl()}/api/testsets?project_id=${projectId}`,
axiosFetcher,
{revalidateOnFocus: false, shouldRetryOnError: false},
)
const {data, error, mutate, isLoading} = useSWR(`/api/testsets?project_id=${projectId}`, {
revalidateOnFocus: false,
shouldRetryOnError: false,
})

return {
testsets: data || [],
Expand Down
Loading