-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre commit hook #2352
Add pre commit hook #2352
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@ashrafchowdury might be worthwhile to compare performance of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashrafchowdury there is a chance that pylint makes everything fails because there are many unresolved errors. :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should disable the pylint checks for now otherwise it will prevent us from pushing the branch |
QA'ed and had no issues ✔️ @mmabrouk |
Description
This PR aims to add a pre-commit and a pre-push hook to check our code format and lint type check before we push the code.
Related Issue
Closes AGE-1441
Related PRs
https://github.com/Agenta-AI/agenta_cloud/pull/527
npm install
otherwise the hook will not work