Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): logout button unclickable issue #2340

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix(frontend): logout button unclickable issue #2340

merged 1 commit into from
Dec 5, 2024

Conversation

ashrafchowdury
Copy link
Collaborator

@ashrafchowdury ashrafchowdury commented Dec 5, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Dec 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 1:36pm
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 1:36pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working Frontend labels Dec 5, 2024
ardaerzin
ardaerzin approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@ardaerzin ardaerzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mmabrouk
mmabrouk requested changes Dec 5, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA'ed sibling PR in cloud and it did not work.. Could it be a sync issue?

mmabrouk
mmabrouk approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see parent issue

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 5, 2024
@mmabrouk mmabrouk merged commit 2b518d2 into main Dec 5, 2024
9 checks passed
@mmabrouk mmabrouk deleted the fix/logout-button-clicking branch December 5, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardaerzin ardaerzin ardaerzin approved these changes

@mmabrouk mmabrouk mmabrouk approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Frontend lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashrafchowdury @mmabrouk @ardaerzin