Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(frontend)[AGE-1405]:: Replace png onboarding image in public folder with a smaller webp image #2335

Merged
merged 2 commits into from
Dec 3, 2024
Merged

enhance(frontend)[AGE-1405]:: Replace png onboarding image in public folder with a smaller webp image #2335

merged 2 commits into from
Dec 3, 2024

Conversation

ardaerzin
Copy link
Contributor

fixes AGE-1405

What has changed?

  • uses a better optimized image in auth page [6+ mbs > 400kb]

@vercel Vercel
Copy link

vercel bot commented Dec 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 3:39pm
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 3:39pm

@ardaerzin ardaerzin marked this pull request as ready for review December 3, 2024 14:59
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Frontend labels Dec 3, 2024
mmabrouk
mmabrouk requested changes Dec 3, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would break cloud as is, since it depends on the png file (until the sibling PR is merged). I suggest we keep both for the moment being until we release and remove this one

@mmabrouk
Copy link
Member

mmabrouk commented Dec 3, 2024

Another way would be to mark this a sibling PR and link the other PR. Otherwise, we would break dev

@ardaerzin
Copy link
Contributor Author

I think this would break cloud as is, since it depends on the png file (until the sibling PR is merged). I suggest we keep both for the moment being until we release and remove this one

went this route for now

@ardaerzin ardaerzin requested a review from mmabrouk December 3, 2024 15:35
@mmabrouk mmabrouk enabled auto-merge December 3, 2024 15:36
mmabrouk
mmabrouk approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ardaerzin !

@mmabrouk mmabrouk merged commit 1212659 into main Dec 3, 2024
7 of 9 checks passed
@mmabrouk mmabrouk deleted the AGE-1405/fix-mobile-auth-screen branch December 3, 2024 15:37
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmabrouk mmabrouk mmabrouk approved these changes

Assignees
No one assigned
Labels
Frontend lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ardaerzin @mmabrouk