Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Set default values in LegacySummary for Observability Analytics #2305

Merged
merged 2 commits into from
Nov 26, 2024
Merged

[Fix] Set default values in LegacySummary for Observability Analytics #2305

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d39b491
set default values
jp-agenta Nov 25, 2024
ac62dfc
Update utils.py
jp-agenta Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions agenta-backend/agenta_backend/apis/fastapi/observability/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,11 +909,11 @@ def parse_legacy_analytics(
for bucket_dto in bucket_dtos:
data_point = LegacyDataPoint(
timestamp=bucket_dto.timestamp,
success_count=bucket_dto.total.count - bucket_dto.error.count,
failure_count=bucket_dto.error.count,
cost=bucket_dto.total.cost,
latency=bucket_dto.total.duration,
total_tokens=bucket_dto.total.tokens,
success_count=(bucket_dto.total.count - bucket_dto.error.count) or 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that we have a minus here. Do you expect one of these to be Null?

failure_count=bucket_dto.error.count or 0,
cost=bucket_dto.total.cost or 0.0,
latency=bucket_dto.total.duration or 0.0,
total_tokens=bucket_dto.total.tokens or 0,
)

data_points.append(data_point)
Expand Down
Loading