Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fixes]: Release Cycle 63 #2302

Merged
merged 16 commits into from
Nov 27, 2024
Merged

[Bug Fixes]: Release Cycle 63 #2302

Changes from 4 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0dcf7dc
refactor (backend): add baseresponse v3 support and backward compatib…
aybruhm Nov 25, 2024
5ff5956
refactor (cli:sdk): set tree attribute to be None if not provided in …
aybruhm Nov 25, 2024
b71bba8
refactor (cli:sdk): revert sdk changes due to duplicate fix (https://…
aybruhm Nov 25, 2024
3c63f76
fix (bug): resolve TypeError: get_field_value_from_trace_tree() missi…
aybruhm Nov 25, 2024
1120c26
Merge branch 'main' into bug-fixes/release-cycle-63
aybruhm Nov 26, 2024
88a18e6
refactor (backend): add support for nodes that are of type list
aybruhm Nov 26, 2024
2f3469c
refactor (backend): add default 0.0 value to resolve TypeError: unsup…
aybruhm Nov 26, 2024
e08da07
refactor (backend): set value type to be Any
aybruhm Nov 26, 2024
3e93e11
refactor (backend): fix parameters required for rag evaluators & late…
aybruhm Nov 26, 2024
36d311f
feat (backend): create remove_trace_prefix utility function
aybruhm Nov 26, 2024
f70121c
chore (backend): remove print debug statements
aybruhm Nov 26, 2024
cf3fd61
chore (backend): leave aggregation of NoneType as is
aybruhm Nov 26, 2024
2a7c50a
refactor (backend): remove deprecated 'span' attribute in 'time' meta…
aybruhm Nov 26, 2024
c9142ba
chore (backend): remove overhead in computing latency and make use of…
aybruhm Nov 26, 2024
2de3761
style (backend): format backend
aybruhm Nov 26, 2024
fa15ed5
refactor (sdk:web): compute latency/duration in sdk properly and upda…
aybruhm Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 30 additions & 8 deletions agenta-backend/agenta_backend/services/evaluators_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,12 +947,23 @@ async def rag_faithfulness(
)

# Turn distributed trace into trace tree
trace = process_distributed_trace_into_trace_tree(output["trace"])
trace = {}
version = output.get("version")
if version == "3.0":
trace = output.get("tree", {})
elif version == "2.0":
trace = output.get("trace", {})

trace = process_distributed_trace_into_trace_tree(trace, version)

# Get value of required keys for rag evaluator
question_val: Any = get_field_value_from_trace_tree(trace, question_key)
answer_val: Any = get_field_value_from_trace_tree(trace, answer_key)
contexts_val: Any = get_field_value_from_trace_tree(trace, contexts_key)
question_val: Any = get_field_value_from_trace_tree(
trace, question_key, version
)
answer_val: Any = get_field_value_from_trace_tree(trace, answer_key, version)
contexts_val: Any = get_field_value_from_trace_tree(
trace, contexts_key, version
)

if None in [question_val, answer_val, contexts_val]:
logging.error(
Expand Down Expand Up @@ -1048,12 +1059,23 @@ async def rag_context_relevancy(
)

# Turn distributed trace into trace tree
trace = process_distributed_trace_into_trace_tree(output["trace"])
trace = {}
version = output.get("version")
if version == "3.0":
trace = output.get("tree", {})
elif version == "2.0":
trace = output.get("trace", {})

trace = process_distributed_trace_into_trace_tree(trace, version)

# Get value of required keys for rag evaluator
question_val: Any = get_field_value_from_trace_tree(trace, question_key)
answer_val: Any = get_field_value_from_trace_tree(trace, answer_key)
contexts_val: Any = get_field_value_from_trace_tree(trace, contexts_key)
question_val: Any = get_field_value_from_trace_tree(
trace, question_key, version
)
answer_val: Any = get_field_value_from_trace_tree(trace, answer_key, version)
contexts_val: Any = get_field_value_from_trace_tree(
trace, contexts_key, version
)

if None in [question_val, answer_val, contexts_val]:
logging.error(
Expand Down
Loading