Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] verbosity in tracing #2286

Merged
merged 2 commits into from
Nov 25, 2024
Merged

[Fix] verbosity in tracing #2286

merged 2 commits into from
Nov 25, 2024

Conversation

jp-agenta
Copy link
Contributor

@jp-agenta jp-agenta commented Nov 21, 2024

Issues

  • closes AGE-1338 ?

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 6:39pm
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 6:39pm

Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jp-agenta

I made some changes. Please take a look at them.

Basically I reverted some of your changes (removing log.info) and instead created an env variable AGENTA_DEBUG that when set to true would toggle the info, otherwise they are hidden.

To see the infos you would now do:
AGENTA_DEBUG=True myscript.py

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 22, 2024
@mmabrouk mmabrouk merged commit 89093b1 into main Nov 25, 2024
9 of 10 checks passed
@mmabrouk mmabrouk deleted the chore/silence-tracing-output branch November 25, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer SDK size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants