Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve description Json diff eval and fix minor issue #1941

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Improve description Json diff eval and fix minor issue #1941

merged 2 commits into from
Aug 9, 2024

Conversation

mmabrouk
Copy link
Member

No description provided.

mmabrouk added 2 commits July 28, 2024 22:24
@mmabrouk
docs(backend): improve desc json diff match
d692856 
improved the description of json diff match settings
@mmabrouk
fix(backend): fix zero devision
3313ef3
@vercel Vercel
Copy link

vercel bot commented Jul 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2024 8:52pm

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 28, 2024
@dosubot dosubot bot added Backend bug Something isn't working labels Jul 28, 2024
@mmabrouk mmabrouk requested a review from jp-agenta July 28, 2024 20:51
@mmabrouk
Copy link
Member Author

@jp-agenta @aybruhm One option we might consider is having undefined/NaN's as outputs.
The current implementation throws an error when the keys are empty.

@mmabrouk mmabrouk requested a review from aybruhm August 4, 2024 09:48
@mmabrouk
Copy link
Member Author

mmabrouk commented Aug 4, 2024

@jp-agenta @aybruhm
meme

aybruhm
aybruhm approved these changes Aug 4, 2024
View reviewed changes
Copy link
Member

@aybruhm aybruhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, LGTM. Thank you for the PR, @mmabrouk!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 4, 2024
@mmabrouk mmabrouk merged commit dec77a7 into main Aug 9, 2024
9 checks passed
@mmabrouk mmabrouk deleted the mmabrouk/fix/fix-json-diff-eval branch August 9, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jp-agenta jp-agenta jp-agenta approved these changes

@aybruhm aybruhm aybruhm approved these changes

Assignees
No one assigned
Labels
Backend bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmabrouk @aybruhm @jp-agenta