Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (sdk): set default values to FuncResponse sdk type #1766

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Jun 6, 2024

Description

This hotfix assigns None as the default value to the usage and cost fields within the FuncResponse SDK type for LLM app outputs that are of type string.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 6, 2024
@dosubot dosubot bot added bug Something isn't working SDK labels Jun 6, 2024
@aybruhm aybruhm requested a review from mmabrouk June 6, 2024 07:30
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @aybruhm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 6, 2024
@mmabrouk mmabrouk merged commit cf09f60 into main Jun 6, 2024
11 of 13 checks passed
@mmabrouk mmabrouk deleted the hotfix/set-default-values-to-funcresponse branch June 6, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer SDK size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants