-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to observability PR #1722
Improvements to observability PR #1722
Conversation
It does not make sense to initialize tracing with the variant_id. Because we are initializing the container with the variant id, however the same container can have multiple variant ids. The logic here was wrong
- Cleaned code - Removed variant stuff
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on the improvements, @mmabrouk. I added some comments.
Thanks for the review @aybruhm I tried again with my example and it worked fine. |
Great work, @mahmoud! I tested using the three options in the documentation, and everything is working fine! |
46539a2
into
1560-age-118-observability-integration-without-using-agenta-hosted-apps
app_id
all the rest is optional.config.toml
create when runningagenta init