Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to observability PR #1722

Conversation

mmabrouk
Copy link
Member

@mmabrouk mmabrouk commented May 30, 2024

  1. Improving to initialization:
  • Initialization now only requires the app_id all the rest is optional.
  • You can now initialize with the help of config.toml create when running agenta init
  1. Fixing issue with api_key
  • Reverted the changes from yesterday. Now the api_key provided by ag.init() is the one that will be used for initializing the client
  1. Cleaning up agenta_init
  2. Removing the initialization of variant_id: The logic there was wrong. We were always using the name of the variant provided at serve time. I removed the whole logic
  3. Adding instrumentation of inputs to all functions even when not named
  4. Reverting to @ag.entrypoint without parenthesis

mmabrouk added 4 commits May 30, 2024 15:21
It does not make sense to initialize tracing with the variant_id. Because we are initializing the container with the variant id, however the same container can have multiple variant ids. The logic here was wrong
- Cleaned code
- Removed variant stuff
Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 7:00pm

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 30, 2024
@dosubot dosubot bot added Backend bug Something isn't working CLI enhancement New feature or request SDK labels May 30, 2024
Copy link
Member

@aybruhm aybruhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on the improvements, @mmabrouk. I added some comments.

@mmabrouk
Copy link
Member Author

Thanks for the review @aybruhm
Can you please try again. The issue you have discovered did not have anything to do with the entrypoint but with the initialization (ag.init).

I tried again with my example and it worked fine.

@aybruhm
Copy link
Member

aybruhm commented May 30, 2024

Thanks for the review @aybruhm Can you please try again. The issue you have discovered did not have anything to do with the entrypoint but with the initialization (ag.init).

I tried again with my example and it worked fine.

Great work, @mahmoud! I tested using the three options in the documentation, and everything is working fine!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 30, 2024
@aybruhm aybruhm merged commit 46539a2 into 1560-age-118-observability-integration-without-using-agenta-hosted-apps May 30, 2024
7 checks passed
@aybruhm aybruhm deleted the fix-obs-pr-2 branch May 30, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend bug Something isn't working CLI enhancement New feature or request lgtm This PR has been approved by a maintainer SDK size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants