Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Logs are not fetched in cloud #1706

Merged
merged 19 commits into from
Jul 17, 2024
Merged

[Enhancement]: Logs are not fetched in cloud #1706

merged 19 commits into from
Jul 17, 2024

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented May 25, 2024

Depends on #369

@vercel Vercel
Copy link

vercel bot commented May 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 11:26am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request Frontend labels May 25, 2024
@bekossy bekossy requested a review from aakrem May 25, 2024 20:37
@bekossy
Copy link
Member Author

bekossy commented Jun 6, 2024 •
edited
Loading

  • Cloud: 40 seconds timeout, 15 seconds delay
  • OSS: 10 seconds timeout, 5 seconds delay

Current Issue:
When there is an error during the application startup, users are forced to wait until the full timeout period elapses before viewing the logs.

Enhancement:
This pull request introduces a new feature that enhances user experience by providing a "Show Logs" button once the delay period (15 seconds for Cloud, 5 seconds for OSS) is met. This button allows users to bypass the remaining timeout and access the logs immediately.

(cc @aakrem)

@bekossy bekossy force-pushed the cloud-issue-369/-enhancement-logs-are-not-fetched-2 branch from 98ce209 to 267ddc6 Compare June 11, 2024 09:27
aakrem
aakrem previously requested changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@aakrem aakrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bekossy let's resolve the conflicts

@bekossy bekossy requested a review from aakrem June 16, 2024 18:12
@bekossy bekossy requested a review from mmabrouk July 6, 2024 09:45
@mmabrouk mmabrouk dismissed aakrem’s stale review July 9, 2024 18:13

conflict resolved

mmabrouk
mmabrouk requested changes Jul 9, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR breaks the current logging in oss.
I deployed this branch to oss.agenta.ai and served a buggy variant. I don't see the logs anymore
=
When I deployed the main branch, I could see the logs.

Note that when I tested this branch with the cloud in staging it worked fine.

@bekossy bekossy requested a review from mmabrouk July 11, 2024 11:24
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 17, 2024
@aakrem aakrem merged commit bd5e765 into main Jul 17, 2024
8 checks passed
@aakrem aakrem deleted the cloud-issue-369/-enhancement-logs-are-not-fetched-2 branch July 17, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aakrem aakrem aakrem approved these changes

@mmabrouk mmabrouk Awaiting requested review from mmabrouk

Assignees
No one assigned
Labels
enhancement New feature or request Frontend lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bekossy @mmabrouk @aakrem