Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide latency and cost columns on filter #1512

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Hide latency and cost columns on filter #1512

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a4e8d1
hide latency and cost columns on filter
bekossy Apr 12, 2024
5fcc65e
added icon to dropdown, fixed cost and latency filters and improved d…
bekossy Apr 14, 2024
a085846
added multiselect filtering in comparison view
bekossy Apr 16, 2024
fa5dafc
filter list of evaluators in comparison view
bekossy Apr 17, 2024
ad58829
modified comparison filters
bekossy Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions agenta-web/src/components/pages/evaluations/evaluationCompare/EvaluationCompare.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ const EvaluationCompareMode: React.FC<Props> = () => {
})

variants.forEach((variant, vi) => {
const isHidden = evalIds.includes(variant.evaluationId)
colDefs.push({
headerComponent: (props: any) => (
<AgCustomHeader {...props}>
Expand All @@ -230,6 +231,7 @@ const EvaluationCompareMode: React.FC<Props> = () => {
</Space>
</AgCustomHeader>
),
hide: !isHidden,
minWidth: 120,
flex: 1,
valueGetter: (params) => {
Expand All @@ -243,6 +245,7 @@ const EvaluationCompareMode: React.FC<Props> = () => {
})

variants.forEach((variant, vi) => {
const isHidden = evalIds.includes(variant.evaluationId)
colDefs.push({
headerComponent: (props: any) => (
<AgCustomHeader {...props}>
Expand All @@ -253,6 +256,7 @@ const EvaluationCompareMode: React.FC<Props> = () => {
</AgCustomHeader>
),
minWidth: 120,
hide: !isHidden,
flex: 1,
valueGetter: (params) => {
const cost = params.data?.variants.find(
Expand Down
Loading