Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix - remove .filter() logic that removes parameters that don't have a value #1471

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Mar 31, 2024

Description

This PR resolves the issue of saving an empty prompt, which results in re-initializing the prompt. The problem was this line of code: .filter((param) => param.default), which strips off parameters without a default value (even if there was one).

Related Issue

Closes #1462

@aybruhm aybruhm requested a review from mmabrouk March 31, 2024 08:16
@aybruhm aybruhm changed the title Bug Fix - remove buggy .filter() logic that removes parameters that don't have a value Bug Fix - remove .filter() logic that removes parameters that don't have a value Mar 31, 2024
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @aybruhm ! I seem to have sent you in a totally wrong 😅 Hope it did not take long to find the right problem.

@mmabrouk mmabrouk merged commit 6dc889c into main Mar 31, 2024
6 checks passed
@mmabrouk mmabrouk deleted the issue-1462/fix-reinitializing-prompt branch March 31, 2024 10:13
@aybruhm
Copy link
Member Author

aybruhm commented Mar 31, 2024

Thanks for the fix @aybruhm ! I seem to have sent you in a totally wrong 😅 Hope it did not take long to find the right problem.

No problem at all! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Saving an empty prompt results in re-initializing the prompt
2 participants