Latency cost in eval #1468
Latency cost in eval #1468
Conversation
There was a problem hiding this comment.
Thanks for the PR @aakrem, great work ,please see my minor comments.
I think the code changes are minimal, and we can revert without any issue if we decide to modify where to track cost/latency from the output of the app to the observability logic. So we should move forward with this without any issue.
Can you please add also the same logic to the comparison view? Thanks!
…genta into latency-cost-in-eval
There was a problem hiding this comment.
@bekossy @aakrem FE tests are still failing. It seems to be a bug in the code:
1) Evaluation Comparison Test
Executing Evaluation Comparison Workflow
Should verify that there are completed evaluations in the list:
TypeError: The following error originated from your application code, not from Cypress.
> Cannot read properties of null (reading 'getColId')
@aakrem I think we should show the total (sum) cost in the main view and not the average. I think it's more interesting, sine it allows the user to understand the cost of their experiments. For the latency, I think it makes sense to show the average, however, I would label it (avg latency).
|
@mmabrouk btw we don't display "average/avg" for the all evaluators average results. displaying average will maybe make some confusion about what't the type of number is for the rest of the columns |
No description provided.