Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update - fix batch processing logic to be parallel #1415

Closed
wants to merge 4 commits into from

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Mar 2, 2024

Description

This PR updates the batch processing logic to run in parallel rather than sequentially.

Related Issue

Closes #1368

@aybruhm aybruhm requested review from mmabrouk and aakrem and removed request for mmabrouk March 2, 2024 23:33
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @aybruhm ! It looks good to me (untested however). Please see my comment.

@aybruhm aybruhm requested a review from mmabrouk March 4, 2024 21:12
@aybruhm
Copy link
Member Author

aybruhm commented Apr 23, 2024

Too many rebases are going on (about 689 files to rebase) after merging main branch into PR branch.

@aybruhm aybruhm closed this Apr 23, 2024
@aybruhm aybruhm deleted the bug-fix/batch-processing-logic branch April 23, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix batch processing logic in the evaluation
2 participants