Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify sidemenu to display config evaluators and run evaluation under Evaluations dropdown #1404

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Feb 20, 2024

Issue #1399

Copy link
Collaborator

@aakrem aakrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Let's keep the submenu always visible and "Evaluations" should not be clickable
  2. Let's remove the background color of the submenu
  3. Let's edit the names of the submenu items
Screenshot 2024-02-23 at 16 49 18

@bekossy
Copy link
Member Author

bekossy commented Feb 27, 2024

TODO:

  • - App navigation cypress test
  • - Single model test cypress test
  • - AB Testing cypress test

@bekossy bekossy force-pushed the issue-1399/-modify-sidemenu-to-display-config-evaluators-and-run-evaluation-under-dropdown branch from 6df90f2 to 0ea5f28 Compare February 28, 2024 13:04
Copy link
Collaborator

@aakrem aakrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bekossy Awesome thank you!

@aakrem aakrem merged commit 849119c into main Feb 29, 2024
6 checks passed
@aakrem aakrem deleted the issue-1399/-modify-sidemenu-to-display-config-evaluators-and-run-evaluation-under-dropdown branch February 29, 2024 12:46
Copy link

sentry-io bot commented Mar 3, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ReferenceError: CalculatorOutlined is not defined CalculatorOutlined(src/components/Sidebar/Sideb... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants