Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: Custom code evaluation aggregation #1347

Merged
merged 7 commits into from
Feb 7, 2024
Merged

Bug Fix: Custom code evaluation aggregation #1347

merged 7 commits into from
Feb 7, 2024

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Feb 7, 2024

Description

This PR resolves the aggregation bug when running custom code evaluation.

Related Issue

Closes #1345

@aybruhm aybruhm requested a review from mmabrouk February 7, 2024 18:08
mmabrouk
mmabrouk requested changes Feb 7, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the fix at all

@aybruhm aybruhm requested a review from mmabrouk February 7, 2024 19:02
mmabrouk
mmabrouk requested changes Feb 7, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @aybruhm That is much better. I have a couple of minor comments

agenta-backend/agenta_backend/services/aggregation_service.py Outdated Show resolved Hide resolved
agenta-backend/agenta_backend/services/aggregation_service.py Outdated Show resolved Hide resolved
agenta-backend/agenta_backend/tasks/evaluations.py Show resolved Hide resolved
agenta-backend/agenta_backend/tasks/evaluations.py Outdated Show resolved Hide resolved
agenta-backend/agenta_backend/tasks/evaluations.py Outdated Show resolved Hide resolved
agenta-backend/agenta_backend/tasks/evaluations.py Outdated Show resolved Hide resolved
@aybruhm aybruhm requested a review from mmabrouk February 7, 2024 19:47
mmabrouk
mmabrouk approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @aybruhm !

@mmabrouk mmabrouk merged commit 06c818e into main Feb 7, 2024
5 of 6 checks passed
@mmabrouk mmabrouk deleted the fix/custom-code-evaluation-aggregation branch February 7, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmabrouk mmabrouk mmabrouk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Aggregation in custom eval does not work
2 participants
@aybruhm @mmabrouk