Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1209/ implement fe changes to playground, eval and deployment view for prompt versioning #1237

Merged
merged 39 commits into from
Jan 25, 2024
Merged

Issue 1209/ implement fe changes to playground, eval and deployment view for prompt versioning #1237

merged 39 commits into from
Jan 25, 2024

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Jan 19, 2024 •
edited
Loading

Notes:

  • When you create a new app, by default there are already 2 revisions
  • Revision dates are the same

@bekossy bekossy requested a review from mmabrouk January 19, 2024 12:31
mmabrouk
mmabrouk requested changes Jan 19, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @bekossy
Only comment is that if you revert in the playground and try to leave you do not get the message telling you that you have unsaved changed (although you do).

@aybruhm aybruhm force-pushed the issue-1210/prompt-vesioning branch from 1dce5e7 to f7ddc76 Compare January 23, 2024 14:33
@aybruhm aybruhm marked this pull request as ready for review January 25, 2024 13:58
@aybruhm aybruhm merged commit ae855f2 into issue-1210/prompt-vesioning Jan 25, 2024
5 checks passed
@aybruhm
Copy link
Member

aybruhm commented Jan 25, 2024

Awesome job @bekossy!

@aakrem aakrem deleted the Issue-1209/-implement-fe-changes-to-playground,-eval-and-deployment-view-for-prompt-versioning branch January 31, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmabrouk mmabrouk mmabrouk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bekossy @aybruhm @mmabrouk