Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Identify & Fix evaluation scenarios lookup query #1221

Closed

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Jan 18, 2024

Description

This PR improves the query for looking up evaluation scenarios for both human and auto evaluations.

Related Issue

Closes #1235

Additional Note

I modified the migration readme documentation.

@aybruhm aybruhm requested a review from aakrem January 18, 2024 18:27
@aybruhm aybruhm marked this pull request as ready for review January 18, 2024 18:27
Copy link
Collaborator

@aakrem aakrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are having the issue in the auto evaluation. I don't see how this pr will solve the issue

@aybruhm
Copy link
Member Author

aybruhm commented Jan 18, 2024

we are having the issue in the auto evaluation.

Currently looking at the auto evaluation.

I don't see how this pr will solve the issue

We needed to remove fetch_links=True from the document query. When we set fetch_links to True in the HumanEvaluationScenario document, its linked documents were also fetched and returned (which made no sense because we were not using them). Removing the argument, beanie ignored fetching the linked documents, thereby improving the lookup time.

cc: @aakrem

@aybruhm aybruhm requested a review from aakrem January 22, 2024 09:11
@aybruhm aybruhm closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve eval scenarios query performance
2 participants