-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluations in backend #1137
Merged
Merged
Evaluations in backend #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmabrouk
commented
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MohammedMaaz @aakrem @aybruhm
Comparison view:
- Currently, each input/row is displayed twice. We need to map the evaluation scenarios from the multiple runs. This should ideally be done in the backend. Here is a simple Python algorithm for how this could be implemented:
from collections import defaultdict
list1 = [('a', 1), ('b', 2)]
list2 = [('a', 10), ('b', 2)]
list3 = [('a', 3), ('b', 2), ('c', 5)]
merged_dict = defaultdict(list)
for lst in [list1, list2, list3]:
for k, v in lst:
merged_dict[k].append(v)
- Input columns are displayed twice. They should be shown only once.
- The order of the columns should be: Input/Expected output/Output var1/Output var2/Results var1/Results var2.
Evaluation view:
- Remove the id column.
- There's no option to shut down failed evaluations. We need a method to stop them.
- There's no way to determine if an evaluation has failed or if an evaluation scenario has failed.
- There's no option to rerun an evaluation.
Evaluators view:
- Exact match should be available from the start. This should probably be handled in the backend. This also applies to all evaluators that don't need configuration.
…/agenta into evaluations-in-backend
Enhancement: Migration issues fix
Main to evaluations in backend
aakrem
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.