Update - refactor telemetry tracking logic in oss #1069
Conversation
|
@devgenix can you please test the implementation (serve from cli (current version) then use in web cloud version to check for any bugs). Thank you! |
|
@devgenix please see above |
|
@devgenix can you look more into this?! |
I just checked out main and it's happening there too. |
|
@devgenix and? |
There was a problem hiding this comment.
I did a re-check after noticing the error to be happening in other branches too.
It happens that the error I was getting earlier was coming from the clashing dependencies of Langchain and Openai in my local environment. Once I resolved it and re-tested this, all was good.
|
|
||
| export const generateOrRetrieveDistinctId = (): string => { | ||
| if (typeof localStorage !== "undefined") { | ||
| let distinctId = localStorage.getItem("posthog_distinct_id") |
There was a problem hiding this comment.
why do we need to generate a posthog distinct id in this case, I though if we leave it empty posthog would take care of all of this automatically
There was a problem hiding this comment.
I made changes because PostHog wasn't keeping IDs unique for user requests.
When I tested it without the current code changes, I noticed that after a while, PostHog started using a different ID for the events been triggered. So, I figured it'd be better to generate a UUID for each user, stick it to their browser, and let PostHog use that as their distinct ID. This way, even if a user takes off for a few days and comes back (unless they clear their browser storage), PostHog will keep on tracking them with the generated UUID as their ID.
Description
This PR refactors the telemetry tracking logic in OSS.
Related Issue
Closes #199_ag-cloud