Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1033/ sync data view in side by side view #1068

Merged
merged 7 commits into from
Dec 19, 2023

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Dec 18, 2023

  • - Single Prompt
  • - Chat Application

Related Issue

Issue #1033

@bekossy bekossy marked this pull request as ready for review December 19, 2023 09:21
Copy link
Contributor

@MohammedMaaz MohammedMaaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the great work @bekossy and @MohammedMaaz
There is only one small usability issue I am going to keep to a future issue. If you start a side by side chat then add a new variant mid-chat, it will have a different history than the other variants that have already started. I think the right behavior is to copy the history from the forked variants,

@mmabrouk mmabrouk merged commit fd3cdc1 into main Dec 19, 2023
7 checks passed
@aakrem aakrem deleted the issue-1033/-Sync-data-view-in-side-by-side-view branch January 31, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants