Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement - Synchroize OSS UI telemetry tracking with CLI #1037

Merged
merged 8 commits into from
Dec 12, 2023
Merged

Enhancement - Synchroize OSS UI telemetry tracking with CLI #1037

merged 8 commits into from
Dec 12, 2023

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Dec 11, 2023 •
edited
Loading

Description

The PR achieves the following:

  • synchronizes OSS tracking (UI) with CLI
  • tracks the user email in cloud and user id in oss
  • tracks new events on the UI: $page_view, variant_saved & app_deployed
  • created a reusable hook for poshog tracking

Related Issue

Closes ag_199 x ag_198

@aybruhm aybruhm requested a review from mmabrouk December 11, 2023 17:16
mmabrouk
mmabrouk approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @aybruhm
@bekossy can you please take a look at it (since you have an issue that might work on the same codebase in cloud).

mmabrouk
mmabrouk approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aybruhm @MohammedMaaz

@mmabrouk mmabrouk merged commit 19305e5 into main Dec 12, 2023
7 checks passed
@mmabrouk mmabrouk deleted the gh/pgh-tracking-in-oss branch December 12, 2023 14:48
@techemmy techemmy mentioned this pull request Mar 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohammedMaaz MohammedMaaz MohammedMaaz approved these changes

@mmabrouk mmabrouk mmabrouk approved these changes

Assignees

@aybruhm aybruhm

@bekossy bekossy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aybruhm @mmabrouk @MohammedMaaz @bekossy