-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement - Improve SDK output format #1025
Enhancement - Improve SDK output format #1025
Conversation
…nd also cleanup imports and entrypoint function
@mmabrouk, the reason for the high number of commits is due to merging the main branch into the feature branch for synchronization. If we change the base branch from Please let me know if any part of my explanation is unclear. Thank you. |
The files that you should review are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aybruhm , thanks a lot for the PR!
However, it's extremely hard to review due to it being a merge together with the PR
Maybe merge main to add-metrics-to-sdk-playground-eval too so that the diff shows only the changes you made?
I've done that, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @aybruhm and sorry for the late answer. Please see the minor comments.
a0a2005
into
feature/add-metrics-to-sdk-playground-evaluation
Description
This PR updates the SDK output format to expect a JSON response with a specific structure, ensuring backward compatibility for existing output formats, and introducing an additional latency field in the JSON response.
Related Issue
Closes first task in #988