Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - Improve SDK output format #1025

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Dec 10, 2023

Description

This PR updates the SDK output format to expect a JSON response with a specific structure, ensuring backward compatibility for existing output formats, and introducing an additional latency field in the JSON response.

Related Issue

Closes first task in #988

@aybruhm aybruhm requested a review from mmabrouk December 10, 2023 13:34
@aybruhm
Copy link
Member Author

aybruhm commented Dec 14, 2023

@mmabrouk, the reason for the high number of commits is due to merging the main branch into the feature branch for synchronization. If we change the base branch from feature/add-metrics-to-sdk-playground-evaluation to main, the additional commits will be eliminated. As this PR is not yet ready for merging into the main branch, a feature branch was created instead.

Please let me know if any part of my explanation is unclear. Thank you.

@aybruhm
Copy link
Member Author

aybruhm commented Dec 14, 2023

@mmabrouk, the reason for the high number of commits is due to merging the main branch into the feature branch for synchronization. If we change the base branch from feature/add-metrics-to-sdk-playground-evaluation to main, the additional commits will be eliminated. As this PR is not yet ready for merging into the main branch, a feature branch was created instead.

Please let me know if any part of my explanation is unclear. Thank you.

The files that you should review are:

Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aybruhm , thanks a lot for the PR!
However, it's extremely hard to review due to it being a merge together with the PR
Maybe merge main to add-metrics-to-sdk-playground-eval too so that the diff shows only the changes you made?

@aybruhm aybruhm requested a review from mmabrouk December 14, 2023 17:36
@aybruhm
Copy link
Member Author

aybruhm commented Dec 14, 2023

Hey @aybruhm , thanks a lot for the PR! However, it's extremely hard to review due to it being a merge together with the PR Maybe merge main to add-metrics-to-sdk-playground-eval too so that the diff shows only the changes you made?

I've done that, thank you.

Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @aybruhm and sorry for the late answer. Please see the minor comments.

examples/async_chat_sdk_output_format/app.py Outdated Show resolved Hide resolved
examples/async_chat_sdk_output_format/app.py Outdated Show resolved Hide resolved
@aybruhm aybruhm requested a review from mmabrouk December 19, 2023 07:40
@aakrem aakrem merged commit a0a2005 into feature/add-metrics-to-sdk-playground-evaluation Dec 21, 2023
3 checks passed
@aakrem aakrem deleted the gh/sdk-output-format-change branch January 19, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants