Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

944 | Feature: File input support in Apps #1010

Merged
merged 6 commits into from
Dec 7, 2023
Merged

944 | Feature: File input support in Apps #1010

merged 6 commits into from
Dec 7, 2023

Conversation

MohammedMaaz
Copy link
Contributor

  • File input support with image preview in Playground
  • File input support with image preview in Evaluations
  • Reusable param inputs Form to introduce consistency
  • Parma inputs validations
  • Refactoring for reusability

Resolves #944

aakrem
aakrem requested changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@aakrem aakrem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Only the run all works, the "Run" button doesn't work
  • Can we improve the ui a bit so we don't show the entire url and provide more space to the images ?
Screenshot 2023-12-07 at 07 58 25
Screen.Recording.2023-12-07.at.09.09.31.mov

@MohammedMaaz
Copy link
Contributor Author

  • Only the run all works, the "Run" button doesn't work
  • Can we improve the ui a bit so we don't show the entire url and provide more space to the images ?
Screenshot 2023-12-07 at 07 58 25 Screen.Recording.2023-12-07.at.09.09.31.mov

Done

@aakrem

@aakrem
Copy link
Collaborator

aakrem commented Dec 7, 2023 •
edited
Loading

@MohammedMaaz hmm right now none of the buttons is working

aakrem
aakrem approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@aakrem aakrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's improve the ui in a different issue!
@MohammedMaaz Beautiful! Thanks!

@aakrem aakrem merged commit a025f3f into main Dec 7, 2023
8 checks passed
@aakrem aakrem deleted the feat/file-input-support-playground branch January 31, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aakrem aakrem aakrem approved these changes

@mmabrouk mmabrouk Awaiting requested review from mmabrouk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File Input Support in the Playground
3 participants
@MohammedMaaz @aakrem @mmabrouk