fixes

agenta-backend/agenta_backend/models/converters.py

@@ -106,6 +106,13 @@ async def human_evaluation_db_to_pydantic(
         variant = await db_manager.get_app_variant_instance_by_id(str(variant_id))
         variant_name = variant.variant_name if variant else str(variant_id)
         variant_names.append(str(variant_name))
+    revisions = []
+    for variant_revision_id in evaluation_db.variant_revisions:
+        variant_revision = await db_manager.get_app_variant_revision_by_id(
+            str(variant_revision_id)
+        )
+        revision = variant_revision.revision
+        revisions.append(str(revision))
 
     return HumanEvaluation(
         id=str(evaluation_db.id),
@@ -120,10 +127,7 @@ async def human_evaluation_db_to_pydantic(
             str(variant_revision)
             for variant_revision in evaluation_db.variant_revisions
         ],
-        revisions=[
-            str(variant_revision.revision)
-            for variant_revision in evaluation_db.variant_revisions
-        ],
+        revisions=revisions,
         testset_id=str(evaluation_db.testset.id),
         testset_name=evaluation_db.testset.name,
         created_at=evaluation_db.created_at,

agenta-backend/agenta_backend/services/db_manager.py

@@ -1225,7 +1225,7 @@ async def update_variant_parameters(
         raise ValueError("Issue updating variant parameters")
 
 
-async def get_app_variant_instance_by_id(variant_id: str):
+async def get_app_variant_instance_by_id(variant_id: str) -> AppVariantDB:
     """Get the app variant object from the database with the provided id.
 
     Arguments:
@@ -1241,6 +1241,25 @@ async def get_app_variant_instance_by_id(variant_id: str):
     return app_variant_db
 
 
+async def get_app_variant_revision_by_id(
+    variant_revision_id: str, fetch_links=False
+) -> AppVariantRevisionsDB:
+    """Get the app variant revision object from the database with the provided id.
+
+    Arguments:
+        variant_revision_id (str): The app variant revision unique identifier
+
+    Returns:
+        AppVariantDB: instance of app variant object
+    """
+
+    variant_revision_db = await AppVariantRevisionsDB.find_one(
+        AppVariantRevisionsDB.id == ObjectId(variant_revision_id),
+        fetch_links=fetch_links,
+    )
+    return variant_revision_db
+
+
 async def fetch_testset_by_id(testset_id: str) -> Optional[TestSetDB]:
     """Fetches a testset by its ID.
     Args:

agenta-backend/agenta_backend/services/evaluation_service.py

@@ -622,14 +622,18 @@ async def create_new_human_evaluation(
         )
 
     variants = [ObjectId(variant_id) for variant_id in payload.variant_ids]
+    variant_dbs = [
+        await db_manager.fetch_app_variant_by_id(variant_id)
+        for variant_id in payload.variant_ids
+    ]
 
     testset = await db_manager.fetch_testset_by_id(testset_id=payload.testset_id)
     # Initialize and save evaluation instance to database
     variant_revisions = [
         await db_manager.fetch_app_variant_revision_by_variant(
-            str(variant.id), int(variant.revision)
+            str(variant_db.id), int(variant_db.revision)
         )
-        for variant in variants
+        for variant_db in variant_dbs
     ]
     eval_instance = HumanEvaluationDB(
         app=app,
@@ -638,7 +642,9 @@ async def create_new_human_evaluation(
         status=payload.status,
         evaluation_type=payload.evaluation_type,
         variants=variants,
-        variant_revisions=variant_revisions,
+        variant_revisions=[
+            ObjectId(str(variant_revision.id)) for variant_revision in variant_revisions
+        ],
         testset=testset,
         created_at=current_time,
         updated_at=current_time,