Merge pull request #2342 from Agenta-AI/fix/no-status-code-passthrough

[Fix] Errors in llm apps freezes the playground
Agenta-AI · Dec 6, 2024 · 73335ee · 73335ee
2 parents e11f848 + 9d856ca
commit 73335ee
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/agenta-cli/agenta/sdk/decorators/routing.py b/agenta-cli/agenta/sdk/decorators/routing.py
@@ -394,7 +394,7 @@ def handle_failure(self, error: Exception):
         log.warning(format_exc().strip("\n"))
         log.warning("--------------------------------------------------")
 
-        status_code = error.status_code if hasattr(error, "status_code") else 500
+        status_code = 500
         message = str(error)
         stacktrace = format_exception(error, value=error, tb=error.__traceback__)  # type: ignore
         detail = {"message": message, "stacktrace": stacktrace}

diff --git a/agenta-web/src/services/api.ts b/agenta-web/src/services/api.ts
@@ -151,7 +151,11 @@ export async function callVariant(
             return response
         })
         .catch(async (error) => {
-            console.log("Unsecure call to LLM App failed:", error?.status)
+            console.log("Unsecure call to LLM App failed:", error)
+
+            if (error?.response?.status !== 401) {
+                throw error
+            }
 
             let response = await axios
                 .post(secure_url, requestBody, {
@@ -163,7 +167,9 @@ export async function callVariant(
                     return response
                 })
                 .catch((error) => {
-                    console.log("Secure call to LLM App failed:", error?.status)
+                    console.log("Secure call to LLM App failed:", error)
+
+                    throw error
                 })
 
             return response
@@ -200,7 +206,11 @@ export const fetchVariantParametersFromOpenAPI = async (
             return response
         })
         .catch(async (error) => {
-            console.log("Unsecure call to LLM App failed:", error?.status)
+            console.log("Unsecure call to LLM App failed:", error)
+
+            if (error?.response?.status !== 401) {
+                throw error
+            }
 
             let response = await axios
                 .get(secure_url, {
@@ -211,7 +221,9 @@ export const fetchVariantParametersFromOpenAPI = async (
                     return response
                 })
                 .catch((error) => {
-                    console.log("Secure call to LLM App failed:", error?.status)
+                    console.log("Secure call to LLM App failed:", error)
+
+                    throw error
                 })
 
             return response