Merge pull request #2364 from Agenta-AI/AGE-1394/-State-mix-up-in-cre…

…ate-new-evaluator-modal (frontend)[AGE-1394]: State mix-up in create new evaluator modal
Agenta-AI · Dec 13, 2024 · 387012f · 387012f
2 parents 6b34d87 + 71db0ff
commit 387012f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 15 deletions.
diff --git a/...-web/src/components/pages/evaluations/autoEvaluation/EvaluatorsModal/Evaluators/index.tsx b/...-web/src/components/pages/evaluations/autoEvaluation/EvaluatorsModal/Evaluators/index.tsx
@@ -22,8 +22,6 @@ type EvaluatorsProps = {
     onSuccess: () => void
     setEvaluatorsDisplay: any
     evaluatorsDisplay: string
-    setSelectedEvaluatorCategory: React.Dispatch<React.SetStateAction<string>>
-    selectedEvaluatorCategory: string
 }
 
 const useStyles = createUseStyles((theme: JSSTheme) => ({
@@ -74,13 +72,12 @@ const Evaluators = ({
     setCloneConfig,
     setEvaluatorsDisplay,
     evaluatorsDisplay,
-    selectedEvaluatorCategory,
-    setSelectedEvaluatorCategory,
 }: EvaluatorsProps) => {
     const classes = useStyles()
     const [searchTerm, setSearchTerm] = useState("")
     const evaluatorTags = getEvaluatorTags()
     const evaluators = useAtom(evaluatorsAtom)[0]
+    const [selectedEvaluatorCategory, setSelectedEvaluatorCategory] = useState("view_all")
 
     const updatedEvaluatorConfigs = useMemo(() => {
         return evaluatorConfigs.map((config) => {
@@ -128,7 +125,7 @@ const Evaluators = ({
                 <div>
                     <div className="flex items-center justify-between">
                         <Radio.Group
-                            defaultValue={"view_all"}
+                            defaultValue={selectedEvaluatorCategory}
                             className={classes.radioBtnContainer}
                             onChange={(e) => setSelectedEvaluatorCategory(e.target.value)}
                         >

diff --git a/...a-web/src/components/pages/evaluations/autoEvaluation/EvaluatorsModal/EvaluatorsModal.tsx b/...a-web/src/components/pages/evaluations/autoEvaluation/EvaluatorsModal/EvaluatorsModal.tsx
@@ -68,7 +68,6 @@ const EvaluatorsModal = ({
         "evaluator_view",
         "list",
     )
-    const [selectedEvaluatorCategory, setSelectedEvaluatorCategory] = useState("view_all")
     const [selectedTestset, setSelectedTestset] = useState("")
 
     const evalConfigFetcher = () => {
@@ -114,8 +113,6 @@ const EvaluatorsModal = ({
                     setCloneConfig={setCloneConfig}
                     setEvaluatorsDisplay={setEvaluatorsDisplay}
                     evaluatorsDisplay={evaluatorsDisplay}
-                    selectedEvaluatorCategory={selectedEvaluatorCategory}
-                    setSelectedEvaluatorCategory={setSelectedEvaluatorCategory}
                 />
             ),
         },
@@ -128,8 +125,6 @@ const EvaluatorsModal = ({
                     setSelectedEvaluator={setSelectedEvaluator}
                     setEvaluatorsDisplay={setEvaluatorsDisplay}
                     evaluatorsDisplay={evaluatorsDisplay}
-                    selectedEvaluatorCategory={selectedEvaluatorCategory}
-                    setSelectedEvaluatorCategory={setSelectedEvaluatorCategory}
                 />
             ),
         },

diff --git a/...eb/src/components/pages/evaluations/autoEvaluation/EvaluatorsModal/NewEvaluator/index.tsx b/...eb/src/components/pages/evaluations/autoEvaluation/EvaluatorsModal/NewEvaluator/index.tsx
@@ -15,8 +15,6 @@ type NewEvaluatorProps = {
     setSelectedEvaluator: React.Dispatch<React.SetStateAction<Evaluator | null>>
     setEvaluatorsDisplay: any
     evaluatorsDisplay: string
-    setSelectedEvaluatorCategory: React.Dispatch<React.SetStateAction<string>>
-    selectedEvaluatorCategory: string
 }
 
 const useStyles = createUseStyles((theme: JSSTheme) => ({
@@ -62,12 +60,11 @@ const NewEvaluator = ({
     setSelectedEvaluator,
     setEvaluatorsDisplay,
     evaluatorsDisplay,
-    selectedEvaluatorCategory,
-    setSelectedEvaluatorCategory,
 }: NewEvaluatorProps) => {
     const classes = useStyles()
     const [searchTerm, setSearchTerm] = useState("")
     const evaluatorTags = getEvaluatorTags()
+    const [selectedEvaluatorCategory, setSelectedEvaluatorCategory] = useState("view_all")
 
     const filteredEvaluators = useMemo(() => {
         let filtered = evaluators
@@ -103,7 +100,7 @@ const NewEvaluator = ({
                 <div>
                     <div className="flex items-center justify-between">
                         <Radio.Group
-                            defaultValue={"view_all"}
+                            defaultValue={selectedEvaluatorCategory}
                             className={classes.radioBtnContainer}
                             onChange={(e) => setSelectedEvaluatorCategory(e.target.value)}
                         >