trigger unsaved changes alert when switching history

Agenta-AI · Jan 21, 2024 · 2b452dd · 2b452dd
1 parent 8e3239f
commit 2b452dd
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 14 deletions.
diff --git a/agenta-web/src/components/Playground/ViewNavigation.tsx b/agenta-web/src/components/Playground/ViewNavigation.tsx
@@ -251,6 +251,7 @@ const ViewNavigation: React.FC<Props> = ({
                         isChatVariant={!!isChatVariant}
                         compareMode={compareMode}
                         setOptParams={setOptParams}
+                        onStateChange={onStateChange}
                     />
                 </Col>
             </Row>

diff --git a/agenta-web/src/components/Playground/Views/ParametersView.tsx b/agenta-web/src/components/Playground/Views/ParametersView.tsx
@@ -153,6 +153,17 @@ const ParametersView: React.FC<Props> = ({
                         </Col>
                         <Col>
                             <Space>
+                                <Tooltip>
+                                    <Button
+                                        onClick={handleHistoryBtn}
+                                        data-cy="history-button"
+                                        type="link"
+                                        icon={compareMode && <HistoryOutlined />}
+                                    >
+                                        {compareMode ? null : "History"}
+                                    </Button>
+                                </Tooltip>
+
                                 {isVariantExisting && (
                                     <Tooltip
                                         placement="bottom"
@@ -168,18 +179,6 @@ const ParametersView: React.FC<Props> = ({
                                     </Tooltip>
                                 )}
 
-                                <Tooltip>
-                                    <Button
-                                        onClick={handleHistoryBtn}
-                                        data-cy="history-button"
-                                        type="link"
-                                        icon={compareMode && <HistoryOutlined />}
-                                        style={{backgroundColor: "#fa8c16", color: "#fff"}}
-                                    >
-                                        {compareMode ? null : "History"}
-                                    </Button>
-                                </Tooltip>
-
                                 <Tooltip
                                     placement="bottom"
                                     title="Save the new parameters for the variant permanently"

diff --git a/agenta-web/src/components/Playground/Views/TestView.tsx b/agenta-web/src/components/Playground/Views/TestView.tsx
@@ -156,6 +156,7 @@ interface TestViewProps {
     isChatVariant?: boolean
     compareMode: boolean
     setOptParams: React.Dispatch<React.SetStateAction<Parameter[] | null>>
+    onStateChange: (isDirty: boolean) => void
 }
 
 interface BoxComponentProps {
@@ -319,6 +320,7 @@ const App: React.FC<TestViewProps> = ({
     isChatVariant,
     compareMode,
     setOptParams,
+    onStateChange,
 }) => {
     const router = useRouter()
     const appId = router.query.app_id as unknown as string
@@ -493,8 +495,8 @@ const App: React.FC<TestViewProps> = ({
         }
     }
 
-    const handleRestore = (id: number) => {
-        const revision = promptRevisions?.revisions.find((rev) => rev.revision === id)
+    const handleRestore = (revisionId: number) => {
+        const revision = promptRevisions?.revisions.find((rev) => rev.revision === revisionId)
 
         setOptParams((prevState: Parameter[] | null) => {
             if (!prevState) {
@@ -522,6 +524,7 @@ const App: React.FC<TestViewProps> = ({
         })
 
         setIsDrawerOpen(false)
+        onStateChange(true)
     }
 
     return (