-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get the Code to Work with Restarts Again #148
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows interpolation on the cubesphere grid ghostcells to have them matchup to the correct locations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #103
When the cubesphere was fully implemented, the restarts stopped working. So, this was solved by no restarting the grid for cubespheres. That is sort of a hack, but there are so many variables that are calculated for the cubesphere that it doesn't make much sense to actually restart it.
Further, restarts have never worked without netCDF files. A reader for binary file containers is included in this pull. That solves the problem of the netCDFs.
Type of change
How Has This Been Tested?
In the tests/restart* directories, there are different tests for restarting the code.
Test configuration
Checklist:
develop
(notmaster
) branchCHANGELOG.md
, summarizing the changes