Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the Code to Work with Restarts Again #148

Closed
wants to merge 1,497 commits into from
Closed

Get the Code to Work with Restarts Again #148

wants to merge 1,497 commits into from

Conversation

aaronjridley
Copy link
Contributor

Description

Addresses #103

When the cubesphere was fully implemented, the restarts stopped working. So, this was solved by no restarting the grid for cubespheres. That is sort of a hack, but there are so many variables that are calculated for the cubesphere that it doesn't make much sense to actually restart it.

Further, restarts have never worked without netCDF files. A reader for binary file containers is included in this pull. That solves the problem of the netCDFs.

Type of change

  • Bug fix - cubesphere restart not working
  • New feature - binary reader for containers

How Has This Been Tested?

In the tests/restart* directories, there are different tests for restarting the code.

Test configuration

  • Operating system: Both Mac and Ubuntu
  • Compiler, version number: gcc 13 (mac) and gcc 11 (ubuntu)
  • I did not use netcdf files for any of the tests

Checklist:

  • [N/A] Make sure you are merging into the develop (not master) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • [N/A] Add a note to CHANGELOG.md, summarizing the changes

@aaronjridley aaronjridley deleted the restart_fix branch April 14, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants