-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exchange messages interpolation #147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the cubesphere grid, the ghostcells don't line up when they go on to a different face. The old way of dealing with this was to put the ghostcells at the location of the cells on the other face. This does not work for the gradient calculator or the advection scheme, which assumes that the cells all line up along constant lines, and can be projected onto the same flat cube face. So, instead, the cells from the other face are interpolated to the location of the ghostcells on the current face. This seems to work for some faces, but doesn't seem to be exact. This needs to be investigated more at a later time.
Type of change
How Has This Been Tested?
The latitude and longitude are message passed in the test and are verified to be in the same location in the ghostcells.
Test configuration
Checklist:
develop
(notmaster
) branchCHANGELOG.md
, summarizing the changes