Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange messages interpolation #147

Merged
merged 23 commits into from
Apr 8, 2024

Conversation

aaronjridley
Copy link
Contributor

Description

In the cubesphere grid, the ghostcells don't line up when they go on to a different face. The old way of dealing with this was to put the ghostcells at the location of the cells on the other face. This does not work for the gradient calculator or the advection scheme, which assumes that the cells all line up along constant lines, and can be projected onto the same flat cube face. So, instead, the cells from the other face are interpolated to the location of the ghostcells on the current face. This seems to work for some faces, but doesn't seem to be exact. This needs to be investigated more at a later time.

Type of change

  • Bug fix - in order to work with the gradient calculator and advection scheme, this needed to be fixed.

How Has This Been Tested?

The latitude and longitude are message passed in the test and are verified to be in the same location in the ghostcells.

Test configuration

  • Operating system: Mac OSX 13.6
  • Compiler, version number: gcc version 13.2

Checklist:

  • [N/A] Make sure you are merging into the develop (not master) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • [N/A] Add a note to CHANGELOG.md, summarizing the changes

@aaronjridley aaronjridley merged commit 502a636 into develop Apr 8, 2024
6 checks passed
@aaronjridley aaronjridley deleted the exchange_messages_interpolation branch April 14, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant