Change output variable names and vastly improve settings checks #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #70 and #144
The output variable names are changed to not have spaces or parentheses.
The input settings checking is simplified and made more consistent - now developers can simply use the get_settings_xx(key, key) functions. These functions check if the keys exist and then set an error flag if they don't. Much more robust!
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Run the default test case.
One issue with testing these things is that the default.json file has correct settings, so if the user sets a setting incorrectly in the aether.json file, it will simply ADD to the settings json and not overwrite the default setting, since this is how json merge works.
Test configuration
Checklist:
develop
(notmaster
) branchCHANGELOG.md
, summarizing the changes