-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error flow catching in code #142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #70 and #97
In making tests and running the code with different configurations, it is clear that the code needs more error catching and reporting. These changes use the report.error functionality and adds more capturing of possible user errors in trying to run the code.
This is not complete, since there are a million ways that the user can mess up running the code, but it adds a lot of catches in that should help. This is a constant process of adding more hooks.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Hopefully, if the user messes up the aether.json file or some other file or makes a bad setting somewhere, the code captures this and reports it. There are no formal tests for this (except for the chemistry test).
Test configuration
Checklist:
develop
(notmaster
) branchCHANGELOG.md
, summarizing the changes