Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nan check #134

Merged
merged 9 commits into from
Aug 13, 2023
Merged

Nan check #134

merged 9 commits into from
Aug 13, 2023

Conversation

rvshetty22
Copy link
Contributor

Description

Added a check to temperature, velocity, and density arma_cubes of neutrals and ions to check for nan and +/- inf values. For testing purposes, indefinite values are inserted into a specified arma_cube in aether.json leading the code to gracefully exit when found.

Type of change

  • New feature (non-breaking change that adds functionality)

How Has This Been Tested?

There is a run_test_nan.sh file under tests/nan to be executed

Test configuration

Operating system: Windows 11, Ubuntu 11.3.0

Checklist:

  • [N/A] Make sure you are merging into the develop (not master) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • [N/A] Add a note to CHANGELOG.md, summarizing the changes

@aaronjridley aaronjridley merged commit 22d7016 into AetherModel:develop Aug 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants