fixes traffic assignment tests #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the rgap test used to pass before the bpr changes and I don't know why it doesn't anymore. Like I said, I don't think the test is valid but I'd still like to understand where the change is coming from. I'll track this at #284. |
pedrocamargo
approved these changes
Jan 16, 2022
pedrocamargo
added a commit
that referenced
this pull request
Mar 30, 2022
* Updates shapely deprecated methods (#281) * Improves performance of triggers (#278) * documentation correction (#282) * French INRETS and bpr2 VD functions (#273) * Fixes styles to expose test failures * Adds the obvious field vot to the modes table and creates and adds a script for compiling that may be useful during development * Closes issue #289 and adds small feature * fixes traffic assignment tests (#293) * Follows the Wikimedia user-agent policy (#295) * Adresses issue #285 (#297) * Allows for skims to be set after the creation of traffic classes * Improvement on skim saving * Fixes creation of skim matrices on multi-class assignment * Threading * Adds connection refresh capability * Stores binaries with all tests * Makes feather optional on import * Removes repeated code Co-authored-by: Danilo Ebbinghaus <[email protected]> Co-authored-by: Arthur Evrard <[email protected]> Co-authored-by: Jan Zill <[email protected]> Co-authored-by: Jan <[email protected]>
Merged
pedrocamargo
added a commit
that referenced
this pull request
Mar 30, 2022
New features: French INRETS and bpr2 VD functions (#273) Adds the obvious field vot (Value-of-Time) to the modes table and creates and adds a script for compiling that may be useful during development Bug fixes/Improvements: Allows for skims to be set after the creation of traffic classes Improvement on skim saving Fixes creation of skim matrices on multi-class assignment Makes feather optional on import Documentation: Adds new instructions for contribution by @pedrocamargo in #275 documentation correction (#282) Software improvements Updates shapely deprecated methods (#281) Improves performance of triggers (#278) Workflow test by @pedrocamargo in #276 fixes traffic assignment tests (#293) Follows the Wikimedia user-agent policy (#295) Co-authored-by: Danilo Ebbinghaus <[email protected]> Co-authored-by: Arthur Evrard <[email protected]> Co-authored-by: Jan Zill <[email protected]> Co-authored-by: Jan <[email protected]>
pedrocamargo
added a commit
that referenced
this pull request
Jul 24, 2022
* Updates shapely deprecated methods (#281) * Improves performance of triggers (#278) * documentation correction (#282) * INRETS and bpr2 VD functions (#273) * French INRETS VD function First implementation of the French INRETS Volume Delay function. Beta is not used but kept for better consistancy across VD functions. * BPR2 implementation First implementation of BPR2 Volume Delay function. This doubles beta above capacity so that fewer vehicles are affected when capacity is exceeded. Double Beta insteed of using a Beta' allow to use only 2 parameters as for other VD functions. Integration into QGIS GUI is also easier * Two small changes around the edges (#288) * Closes issue #289 and adds small feature * Fixes long-standing formatting issue * fixes traffic assignment tests (#293) * Follows the Wikimedia user-agent policy (#295) * Makes sure we follow the Wikimedia user agent policy https://meta.wikimedia.org/wiki/User-Agent_policy * Adresses issue #285 (#297) * Allows for skims to be set after the creation of traffic classes * Improvement on skim saving * Updates example with change in skim saving method * Fixes typo * Fixes creation of skim matrices on multi-class assignment * Fixes final skim for travel time and introduces basic testing * Fixes example with new skimming standards * cleans tests * Relocates and Fixes path saving tests * Updates tests * QGIS adjustments (#280) * Threading * Adds connection refresh capability * Stores binaries with all tests * Makes feather optional on import * Removes repeated code * Bumps up version * Adds doc version to index * Bumps version for new release * closes issue #303 * closes issue #303 (#304) * Fixes issue 307 * Improves database structure (#310) * Improves database structure * Improves database structure * numpy 1.22 is still not the default * CI workflow to generate binaries for different NumPy versions * Sets up better tests * Sets up better tests * numpy 1.22 is still not the default * Cleans test * Run black on all source files * Adding conda_forge_recipe * Support for multiple projects (#323) * Matrix from list (#325) * Pedro/new test fix (#322) * Speeding up OSM network import * only run actions that require secrets from the Aequilbrae account. (#329) * Support logging for multiple projects, log most warnings instead of raising them (#327) * one logger per project, log most warnings instead of raising them * Multiple changes * renamed starts_logging and combine with log.py * moved additional setup code to __init__.py * undo falsely blackened line * process feedback * cleanup ci setup for unittests - do errors still occur? * Small changes to the Delaunay line creation in trying to identify consistent breaking point Co-authored-by: Danilo Ebbinghaus <[email protected]> Co-authored-by: Arthur Evrard <[email protected]> Co-authored-by: Jan Zill <[email protected]> Co-authored-by: Jan <[email protected]> Co-authored-by: Jamie Cook <[email protected]> Co-authored-by: PelleK <[email protected]> Co-authored-by: Pelle Koster <[email protected]> Co-authored-by: pveigadecamargo <[email protected]>
pedrocamargo
added a commit
that referenced
this pull request
Nov 3, 2022
* Updates shapely deprecated methods (#281) * Improves performance of triggers (#278) * documentation correction (#282) * INRETS and bpr2 VD functions (#273) * French INRETS VD function First implementation of the French INRETS Volume Delay function. Beta is not used but kept for better consistancy across VD functions. * BPR2 implementation First implementation of BPR2 Volume Delay function. This doubles beta above capacity so that fewer vehicles are affected when capacity is exceeded. Double Beta instead of using a Beta' allow to use only 2 parameters as for other VD functions. Integration into QGIS GUI is also easier * Fixes styles to expose test failures * Fixes styles to expose test failures * reverts white space changes in bpr * Fixes inrets tests * Two small changes around the edges (#288) * Adds the obvious field vot to the modes table and creates and adds a script for compiling that may be useful during development * Update tests/compile.py Co-authored-by: Jamie Cook <[email protected]> * Fixes import * Closes issue #289 and adds small feature * Fixes long-standing formatting issue * fixes traffic assignment tests (#293) Brilliant work, @janzill That original test was really out of whack!!! * Follows the Wikimedia user-agent policy (#295) * Makes sure we follow the Wikimedia user agent policy https://meta.wikimedia.org/wiki/User-Agent_policy * Adresses issue #285 (#297) * Allows for skims to be set after the creation of traffic classes * Improvement on skim saving * Updates example with change in skim saving method * Fixes typo * Fixes creation of skim matrices on multi-class assignment * Fixes final skim for travel time and introduces basic testing * Fixes example with new skimming standards * cleans tests * Relocates and Fixes path saving tests * Updates tests * QGIS adjustments (#280) * Threading * Adds connection refresh capability * Stores binaries with all tests * Makes feather optional on import * Removes repeated code * Bumps up version * Adds doc version to index * Bumps version for new release * closes issue #303 * closes issue #303 (#304) * Fixes issue 307 * Improves database structure (#310) * Improves database structure * Improves database structure * numpy 1.22 is still not the default * CI workflow to generate binaries for different NumPy versions * Sets up better tests * Sets up better tests * numpy 1.22 is still not the default * use temp dir * guessing this is a case problem * guessing this is a case problem * guessing this is a case problem * it was a case issue * Cleans test * Run black on all source files * Update build_linux.yml * Adding conda_forge_recipe * Support for multiple projects (#323) * Matrix from list (#325) * Pedro/new test fix (#322) * Fixes linux building * Fixes linux building * Speeding up OSM network import * only run actions that require secrets from the Aequilbrae account. (#329) * Support logging for multiple projects, log most warnings instead of raising them (#327) * one logger per project, log most warnings instead of raising them * Multiple changes * renamed starts_logging and combine with log.py * moved additional setup code to __init__.py * undo falsely blackened line * process feedback * cleanup ci setup for unittests - do errors still occur? * Edit the correct ci file * we do need more requirements * run in docker to improve isolation * apt get update Co-authored-by: Pelle Koster <[email protected]> * Small changes to the Delaunay line creation in trying to identify consistent breaking point * Fix some warnings Co-authored-by: Pelle Koster <[email protected]> * Refactor tests to pytest (#331) * Refactor tests * Cleanup and some comments * fix tests * process feedback * Update tests/aequilibrae/conftest.py Co-authored-by: Jamie Cook <[email protected]> * rescope session-scoped fixtures inside a class to class scope to avoid confusion * fix trailing whitespace Co-authored-by: Pelle Koster <[email protected]> Co-authored-by: Jamie Cook <[email protected]> * change the check for secrets from repo_owner to has_secret (#333) * better deal with np.memmap open files (#335) Co-authored-by: Pelle <[email protected]> * Adding capability of importing and exporting networks in GMNS format (#330) * Pedro/fixes numpy changes (#342) * Fixes nan to num * Chipping along transit structure * Fixes tests * Uses new version of Numpy for Windows 3.10 only * address issues from review * unneeded Co-authored-by: pveigadecamargo <[email protected]> Co-authored-by: Jamie Cook <[email protected]> * Updates actions (#341) * Updates actions * Chipping along transit structure Co-authored-by: pveigadecamargo <[email protected]> Co-authored-by: Jamie Cook <[email protected]> * Fixes issue #344 (#345) * Fixes issue #344 Co-authored-by: François P <[email protected]> * Bumps up version * Bumps up version (#346) Co-authored-by: pveigadecamargo <[email protected]> * bug fix (#347) * Updates actions (#349) Co-authored-by: pveigadecamargo <[email protected]> * Update Develop * stops using Kumi endpoint Co-authored-by: Danilo Ebbinghaus <[email protected]> Co-authored-by: Arthur Evrard <[email protected]> Co-authored-by: Jan Zill <[email protected]> Co-authored-by: Jan <[email protected]> Co-authored-by: Jamie Cook <[email protected]> Co-authored-by: PelleK <[email protected]> Co-authored-by: Pelle Koster <[email protected]> Co-authored-by: pveigadecamargo <[email protected]> Co-authored-by: Jamie Cook <[email protected]> Co-authored-by: Pelle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pedrocamargo I don't think comparing rgap for converged bfw and cfw is a valid test, the only thing we can guarantee is that both are less than the specified target. We can, however, compare the number of iterations between tests.