Add missing fields and change register methods

[lukaszzborek]

Breaking:

• Change AddIRacingDataApi methods to return IHttpClientBuilder instead of IServiceCollection (Change "AddIRacingDataApi" to return "IHttpClientBuilder" #175)

Other:

• Add missing rain related fields
• Add method to get weather forecast from schedule (GetSeason)

[AdrianJSClark]

The bulk of these changes are great. Thanks very much for the contribution!

I'm just a bit concerned merging the weather forecast when the values are so unfriendly. If we can work on that class so that people using it don't have to have so much knowledge of how the values are returned I think that would be much more useful.

Due to the breaking change included, I think this change will have to wait and be included with the Season 3 milestone release in a couple of weeks. If there are any particular parts you want merged and released before then, please open a smaller PR and let me know.

[AdrianJSClark]

Many of the properties here need a converter. Their values appear to be converted to avoid decimal places. An example is the AirTemp property which may have a value like 2410 in the response, however int he iRacing UI that will be displayed as 24°C. This I assume is dividing by 100 then rounding to the nearest whole number. A value of 1954 will be displayed as 20°C (1954 / 100 = 19.54 which rounded to the nearest whole number is 20).

I think the full list of properties which will require this conversion are:

• AirTemp
• RawAirTemp
• RelHumidity
• PrecipitationChance

The CloudCover field appears to use a different conversion. It needs to be divided by 10 instead. So a value of 113 will become 11.3% or, as shown in the iRacing UI, 11% (rounded down).

I can't work out what units the WindSpeed or WindDir are in. The WindDir value doesn't convert directly to the WindDirection enumeration (unfortunately). Looking at the sample file you used in the test and some of my own data I think that WindDir could be in degrees. Meaning 0 = North, 180 = South. I'll have to check on the forums though.

[lukaszzborek]

I have changed the types and added converters.
I also saw your comments in the iRacing forum, so I will wait for your answer. My analysis of wind speed indicates it is measured in meters per second, which is a bit strange because this unit is not used elsewhere (in lookup I see only mph and kph). When I convert it to km/h, it's nearly the same as in the UI in the weather summary (not the forecast). I also convert the wind direction from degrees to a rounded direction.

[AdrianJSClark]

Jason got back with some fantastic detail on the thread: https://forums.iracing.com/discussion/comment/541516/#Comment_541516

If you're able to update things that would be great.

Just let me know if you would like me to take care of it. I'll probably be working on this over the weekend as I'm racing and live streaming tonight.

[lukaszzborek]

Nice, I will correct it today, but most of it is already done.

[lukaszzborek]

I think is done, added comments for all properties and fix converters

[AdrianJSClark]

Ignore the failing build. That's due to permissions I've not managed to work out for external people submitting pull requests. Sorry about that.

[lukaszzborek]

The bulk of these changes are great. Thanks very much for the contribution!

I'm just a bit concerned merging the weather forecast when the values are so unfriendly. If we can work on that class so that people using it don't have to have so much knowledge of how the values are returned I think that would be much more useful.

Due to the breaking change included, I think this change will have to wait and be included with the Season 3 milestone release in a couple of weeks. If there are any particular parts you want merged and released before then, please open a smaller PR and let me know.

Yes, it is a good idea to wait for the new season with the breaking changes. Other things can also wait. Currently, I am using my own build in the app.

[AdrianJSClark]

Thanks for the contribution, @lukaszzborek!! Awesome stuff which is much appreciated.