Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granite include top level fixes #3457

Conversation

niekraaijmakers
Copy link
Contributor

Currently, properties on the top level of the snippet are ignored and not included.
This forces you to put them on the include level.

With this PR, the snippet top level values count, unless overridden by specifying it on the include level.
Also, the default resourceType is now set to the container resource type.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 55.69%. Comparing base (ef4f406) to head (4361b7c).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
...mpl/include/NamespaceDecoratedValueMapBuilder.java 21.42% 10 Missing and 1 partial ⚠️
...ponents/impl/include/NamespaceResourceWrapper.java 60.00% 2 Missing ⚠️
...ude/NamespacedTransformedResourceProviderImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3457      +/-   ##
============================================
+ Coverage     55.54%   55.69%   +0.14%     
- Complexity     5582     5601      +19     
============================================
  Files           728      728              
  Lines         29775    29856      +81     
  Branches       3884     3901      +17     
============================================
+ Hits          16540    16627      +87     
+ Misses        11684    11670      -14     
- Partials       1551     1559       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidjgonzalez davidjgonzalez merged commit 0a442d7 into Adobe-Consulting-Services:master Oct 29, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants