Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated browser-warning user agent parsing to precompiled regex #1

Conversation

itsRaCl
Copy link

@itsRaCl itsRaCl commented Aug 28, 2024

Proposed Changes

@itsRaCl
Copy link
Author

itsRaCl commented Aug 28, 2024

@AdityaJ2305 can you reivew this and merge if you find the changes okay

Copy link
Owner

@AdityaJ2305 AdityaJ2305 Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we getting config of browserslist particularly production key array from package.json as there is no any .browserslistrc file ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's fetching it from the browserslist key in the package.json and depending on the NODE_ENV variable set during building the app it'll fetch the appropriate lists to refer to

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it thanks

@AdityaJ2305
Copy link
Owner

Hey, we can add a script in build key which is something like this
"build": "npm run generate-build-meta && npm run supported-browsers && npm run build:react",
so that whenever there is any change in config of browserlist on the time of building updated regex will be generated ?
let me know your views

@itsRaCl
Copy link
Author

itsRaCl commented Aug 28, 2024

We can but I think we should ask one of the core devs before making this change..
This is changing the actual build process so better to ask before hand

@AdityaJ2305
Copy link
Owner

yes absolutely , but it is important to consider so that we don't need to run the command manually on configuration changes to generate updated regex . Let me ask to them

@AdityaJ2305 AdityaJ2305 merged commit 7fe9561 into AdityaJ2305:issues/8403/Warning_for_Unsupported_Browsers Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants