Sharks/Bahareh #17
Open
Sharks/Bahareh #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spitsfire
reviewed
Jul 23, 2022
There was a problem hiding this comment.
Great job, Bahareh! While these days we don't run into issues with JavaScript files loading faster than the html content can. That can make adding event handlers to HTML elements tricky.
It's standard practice to group all our event handlers and "register" them using the COMContentLoaded event at the end of the file. You may have seen function calls like this in the Learn platform:
const registerEventHandler = () => {
realTimeButton.addEventListener('click', saveCity);
// the rest of the event handlers here
};
document.addEventHandler('DOMContentLoaded', registerEventHandlers);
Comment on lines
+34
to
+47
| .then((response) => { | ||
| console.log(response); | ||
| return response.data.current.temp; | ||
| }) | ||
| .then((response)=>{ | ||
| console.log(response); | ||
| return Math.floor((response - 273.15) * 9/5 + 32) | ||
| }) | ||
| .then((response)=>{ | ||
| console.log(response); | ||
| state.temp=response | ||
| tempContainer.textContent=`${state.temp}`; | ||
|
|
||
| }) |
There was a problem hiding this comment.
Ooo nice job learning how to chain promises!
| const saveCity=()=>{ | ||
| const cityName= document.getElementById('input').value; | ||
| state.city=cityName | ||
| console.log(state.city); |
There was a problem hiding this comment.
don't forget to take out debugging print statements like this out for final submissions
Suggested change
| console.log(state.city); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.