Sapphire - Monica L & Charlie J #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tildeee
reviewed
Aug 14, 2023
There was a problem hiding this comment.
Hi Charlie and Monica! I am so sorry for this late review, it's coming in... about three months late? I know a lot of things have changed since then.
Regardless, good work on this project. You all practiced semantic HTML and some CSS styling and met all of the project requirements. I appreciate the work!
Comment on lines
+1
to
+5
| <img alt= "" src="" > | ||
|
|
||
| <img alt= "" src="" > | ||
|
|
||
| <img alt= "" src="" > |
There was a problem hiding this comment.
Hmmm, what happened here? :O
| <section class="footer-container"> | ||
| <footer class="footer-banner"> | ||
| <a href="https://www.indeed.com/">Careers at Cozy Campground</a> | ||
| <a href="mailto:[email protected]">Contact Us</a> |
Comment on lines
+36
to
+41
| <figure> | ||
| <img src="/assets/lakecrescent.jpeg" alt="Washington in the Summer"> | ||
| <figcaption> | ||
| Look how beautiful Washington is in the summer! Source: | ||
| </figcaption> | ||
| </figure> |
There was a problem hiding this comment.
Great use of <figure> and <figcaption>! Minor, but the copy says "Source:" and doesn't point anywhere haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.