-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tara Alsaidi - Lions C18 #38
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you have two copies of every CSS file. It would be good to keep the repo clean by removing unused files.
Personal Portfolio Site
What We're Looking For
Feature | Feedback |
---|---|
Baseline | |
Appropriate Git Usage | ✅ |
Answered comprehension questions | ✅ |
Page fully loads | ✅ |
No broken links (regular or images) | ✅ Mostly |
Includes at least 3 pages and styling | ✅ |
HTML | |
Uses the high-level tags for organization: header, footer, main |
✅ |
Appropriately using semantic tags: section, article , etc. |
✅ |
All images include alternate text | ✅ |
CSS | |
Using class and ID names in style declarations | ✅ |
Style declarations are DRY | Mostly |
Uses Flexbox and/or Grid | ✅ |
Overall | ✅ |
Coming from a background in operations, Tara utilizes data to drive solutions that meet needs while supporting healthy work culture for all. | ||
All that has changed is the language (or, languages) used to reach those solutions. </p> | ||
<br> | ||
<img src="../images/computer image.jpeg" alt="old-school computer graphic"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Image URLs should not have a space in them, it causes errors. Make sure when you add assets and name them to remove spaces!
text-decoration: none; | ||
} | ||
|
||
a:active { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this property here is the same as the one for a:link
, you can do:
a:link, a:active {
text-decoration: none;
}
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions