Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tara Alsaidi - Lions C18 #38

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

cafedes2moulins
Copy link

@cafedes2moulins cafedes2moulins commented Nov 23, 2022

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Yes, the HTML validator did not like the final / at the end of my <img> tags, so I removed them. It also took issue with my <section> tags not having corresponding headers and recommended I used <div> instead. I did not make this change because it was my understanding that using <div> is not semantic HTML.
Why is it important to consider and use semantic HTML? to give meaning to the sometimes difficult to decipher and continuous flow of text that is HTML
How did you decide to structure your CSS? I created a general style sheet for elements that carried across documents, and then I created a specific stylesheet for each page that I linked afterwards so that any style decisions made in these sheets would override the general ones
What was the most challenging piece of this assignment? Firstly, trying to understand what visual elements make a website look put together instead of DIY. But mostly, I am still struggling with getting things where I want them to be on the page. Do not even get me started on responsive web design.
Describe one area that you gained more clarity on when completing this assignment I have a better understanding of the challenges of manipulating different elements in space and the ways that Flexbox and CSS Grids can help make things easier.
Did you deploy to GitHub Pages? If so, what is the URL to your website? It's not ready yet. Trust me.

Copy link

@nancy-harris nancy-harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you have two copies of every CSS file. It would be good to keep the repo clean by removing unused files.

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage
Answered comprehension questions
Page fully loads
No broken links (regular or images) ✅ Mostly
Includes at least 3 pages and styling
HTML
Uses the high-level tags for organization: header, footer, main
Appropriately using semantic tags: section, article, etc.
All images include alternate text
CSS
Using class and ID names in style declarations
Style declarations are DRY Mostly
Uses Flexbox and/or Grid
Overall

Coming from a background in operations, Tara utilizes data to drive solutions that meet needs while supporting healthy work culture for all.
All that has changed is the language (or, languages) used to reach those solutions. </p>
<br>
<img src="../images/computer image.jpeg" alt="old-school computer graphic">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image URLs should not have a space in them, it causes errors. Make sure when you add assets and name them to remove spaces!

text-decoration: none;
}

a:active {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this property here is the same as the one for a:link, you can do:

a:link, a:active {
    text-decoration: none;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants