Merge branch '52-ci-check-that-all-labs-builds-without-any-warnings' …

…into 'main'

CI: check that all labs builds without any warnings

Closes #52

See merge request feng/training/labs_solar_system!27

.gitlab-ci.yml

@@ -9,15 +9,17 @@ sphinx:
     paths:
       - doc/_build/html/*
 
-solutions:
+check_builds:
   services:
     - image:ada-trainings
   stage: build
   script:
     - mkdir -p alire/cache/
     - cp -r $HOME/mage_*/alire/cache/dependencies alire/cache
     - cp -r $HOME/mage_* alire/cache/dependencies
+    - export ADAFLAGS="-Werror"
     - make build_solutions
+    - make build_problems
 
 check_templates:
   services:

Makefile

@@ -84,6 +84,14 @@ generate_subprogram_contracts: $(template_subprogram_contracts)
 		adacut -m answer $$f > src/adv_270_subprogram_contracts/answers/$$(basename $$f); \
 	done
 
+build_problems:
+	set -e; \
+    for lab in "Array_Types" "Record_Types" "Subprograms" "Packages" "Private_Types" "Access_Types" \
+	"Exceptions" "Interfacing_With_C" "Tasking_Protected_Objects" "Subprogram_Contracts"; do \
+		echo $$lab; \
+		Mode=Problem Lab="$$lab" alr build; \
+	done
+
 build_solutions:
 	set -e; \
     for lab in "Array_Types" "Record_Types" "Subprograms" "Packages" "Private_Types" "Access_Types" \

README.md

@@ -50,7 +50,8 @@ will select a new main file, which contains a solution for each lab.
 Warning: After having changed the "Mode" variable, you may need to recompile the project by force,
 by cleaning it.
 
-All solutions should run out of the box, if they don't it is a bug, feel free to open a ticket.
+All solutions and problems should run out of the box, if they don't it is a bug, feel free to open
+a ticket.
 
 ## Known issues
 

src/000_getting_started/src/getting_started_main.adb

@@ -44,9 +44,8 @@ procedure Getting_Started_Main is
 begin
    Window :=
      Create_Window
-       (Width  => Integer (Width),
-        Height => Integer (Height),
-        Name   => "Bouncing ball");
+       (Width => Integer (Width), Height => Integer (Height),
+        Name  => "Bouncing ball");
    Canvas := Get_Canvas (Window);
 
    Next := Clock + Period;
@@ -65,10 +64,8 @@ begin
       Y := Y + Speed_Y;
 
       Draw_Sphere
-        (Canvas   => Canvas,
-         Position => (X, Y, 0.0),
-         Radius   => Ball_Radius,
-         Color    => Red);
+        (Canvas => Canvas, Position => (X, Y, 0.0), Radius => Ball_Radius,
+         Color  => Red);
 
       Handle_Events (Window);
 

src/050_array_types/src/array_types_main.adb

@@ -22,6 +22,12 @@ with Ada.Real_Time; use Ada.Real_Time;
 with Mage;          use Mage;
 with Mage.Draw;     use Mage.Draw;
 with Mage.Event;    use Mage.Event;
+
+--  TODO: Remove these two lines once Cos and Sin are used
+pragma Warnings (Off,
+   "no entities of ""Float_Maths"" are referenced");
+pragma Warnings (Off,
+   "use clause for package ""Float_Maths"" has no effect");
 with Float_Maths;   use Float_Maths;
 
 procedure Array_Types_Main is
@@ -54,6 +60,9 @@ procedure Array_Types_Main is
    --  reference to the application window
    Window : Window_ID;
 
+   --  TODO: Remove once you are drawing on the screen
+   pragma Warnings (Off,
+      "variable ""Canvas"" is assigned but never read");
    --  reference to the graphical canvas associated with the application window
    Canvas : Canvas_ID;
 

src/050_array_types/template/array_types_main.adb

@@ -22,6 +22,14 @@ with Ada.Real_Time; use Ada.Real_Time;
 with Mage;          use Mage;
 with Mage.Draw;     use Mage.Draw;
 with Mage.Event;    use Mage.Event;
+--$ begin question
+
+--  TODO: Remove these two lines once Cos and Sin are used
+pragma Warnings (Off,
+   "no entities of ""Float_Maths"" are referenced");
+pragma Warnings (Off,
+   "use clause for package ""Float_Maths"" has no effect");
+--$ end question
 with Float_Maths;   use Float_Maths;
 
 procedure Array_Types_Main is
@@ -66,6 +74,11 @@ procedure Array_Types_Main is
    --  reference to the application window
    Window : Window_ID;
 
+   --$ begin question
+   --  TODO: Remove once you are drawing on the screen
+   pragma Warnings (Off,
+      "variable ""Canvas"" is assigned but never read");
+   --$ end question
    --  reference to the graphical canvas associated with the application window
    Canvas : Canvas_ID;
 

src/060_record_types/answers/record_types_main.adb

@@ -34,7 +34,8 @@ procedure Record_Types_Main is
    --  that rotate
    subtype Rotating_Bodies_T is Bodies_Enum_T range Earth .. Satellite;
 
-   --  define a type Body_T to store every information about a body
+   --  replace the definition of Body_T by a type that stores every information
+   --  about a body:
    --   X, Y, Distance, Speed, Angle, Color type is RGBA_T, Radius
    type Body_T (Visible : Boolean := True) is record
       X            : Float;

src/060_record_types/src/record_types_main.adb

@@ -22,10 +22,23 @@ with Ada.Real_Time; use Ada.Real_Time;
 with Mage;          use Mage;
 with Mage.Draw;     use Mage.Draw;
 with Mage.Event;    use Mage.Event;
+
+--  TODO: Remove once Cos and Sin are used
+pragma Warnings (Off,
+    "no entities of ""Float_Maths"" are referenced");
+pragma Warnings (Off,
+    "use clause for package ""Float_Maths"" has no effect");
 with Float_Maths;   use Float_Maths;
 
 procedure Record_Types_Main is
 
+   --  TODO: Remove once lab is done
+   pragma Warnings (Off,
+      "not referenced");
+   pragma Warnings (Off,
+      "never read and never assigned");
+   pragma Warnings (Off, "assigned but never read");
+
    --  define type Bodies_Enum_T as an enumeration of Sun, Earth, Moon,
    --  and Satellite
    type Bodies_Enum_T is (Sun, Earth, Moon, Satellite);
@@ -34,8 +47,10 @@ procedure Record_Types_Main is
    --  that rotate
    subtype Rotating_Bodies_T is Bodies_Enum_T range Earth .. Satellite;
 
-   --  define a type Body_T to store every information about a body
+   --  replace the definition of Body_T by a type that stores every information
+   --  about a body:
    --   X, Y, Distance, Speed, Angle, Color type is RGBA_T, Radius
+   subtype Body_T is Integer; -- TODO: Replace by record type
 
    --  define type Bodies_Array_T as an array of Body_T indexed by bodies
    type Bodies_Array_T is array (Bodies_Enum_T) of Body_T;

src/060_record_types/template/record_types_main.adb

@@ -22,9 +22,26 @@ with Ada.Real_Time; use Ada.Real_Time;
 with Mage;          use Mage;
 with Mage.Draw;     use Mage.Draw;
 with Mage.Event;    use Mage.Event;
+--$ begin question
+
+--  TODO: Remove once Cos and Sin are used
+pragma Warnings (Off,
+    "no entities of ""Float_Maths"" are referenced");
+pragma Warnings (Off,
+    "use clause for package ""Float_Maths"" has no effect");
+--$ end question
 with Float_Maths;   use Float_Maths;
 
 procedure Record_Types_Main is
+   --$ begin question
+
+   --  TODO: Remove once lab is done
+   pragma Warnings (Off,
+      "not referenced");
+   pragma Warnings (Off,
+      "never read and never assigned");
+   pragma Warnings (Off, "assigned but never read");
+   --$ end question
 
    --  define type Bodies_Enum_T as an enumeration of Sun, Earth, Moon,
    --  and Satellite
@@ -34,8 +51,11 @@ procedure Record_Types_Main is
    --  that rotate
    subtype Rotating_Bodies_T is Bodies_Enum_T range Earth .. Satellite;
 
-   --  define a type Body_T to store every information about a body
+   --  replace the definition of Body_T by a type that stores every information
+   --  about a body:
    --   X, Y, Distance, Speed, Angle, Color type is RGBA_T, Radius
+   --$ line question
+   subtype Body_T is Integer; -- TODO: Replace by record type
    --$ begin answer
    type Body_T (Visible : Boolean := True) is record
       X            : Float;

src/070_subprograms/answers/subprograms_main.adb

@@ -66,10 +66,6 @@ procedure Subprograms_Main is
 
    --  implement a function to compute the X coordinate
    --  x of the reference + distance * cos(angle)
-   function Compute_X
-     (Body_To_Move : Body_T;
-      Turns_Around : Body_T) return Float;
-
    function Compute_X
      (Body_To_Move : Body_T;
       Turns_Around : Body_T) return Float
@@ -80,9 +76,6 @@ procedure Subprograms_Main is
 
    --  implement a function to compute the Y coordinate
    --  y of the reference + distance * sin(angle)
-   function Compute_Y
-     (Body_To_Move : Body_T;
-      Turns_Around : Body_T) return Float;
 
    function Compute_Y
      (Body_To_Move : Body_T;
@@ -93,8 +86,6 @@ procedure Subprograms_Main is
    end Compute_Y;
 
    --  move a given body over one time step
-   procedure Move
-     (Bodies : in out Bodies_Array_T; Body_To_Move_Index : Bodies_Enum_T);
 
    procedure Move
      (Bodies : in out Bodies_Array_T; Body_To_Move_Index : Bodies_Enum_T) is
@@ -110,8 +101,6 @@ procedure Subprograms_Main is
       Body_To_Move.Angle := Body_To_Move.Angle + Body_To_Move.Speed;
    end Move;
 
-   procedure Draw_Body (Object : Body_T; Canvas : Canvas_ID);
-
    procedure Draw_Body (Object : Body_T; Canvas : Canvas_ID) is
    begin
       Draw_Sphere

src/070_subprograms/src/subprograms_main.adb

@@ -25,6 +25,8 @@ with Mage.Event;    use Mage.Event;
 with Float_Maths;   use Float_Maths;
 
 procedure Subprograms_Main is
+   --  TODO: Remove once subprograms are implemented
+   pragma Warnings (Off, "not referenced");
 
    --  define type Bodies_Enum_T and Rotating_Bodies_T
    type Bodies_Enum_T is (Sun, Earth, Moon, Satellite, Comet);
@@ -64,12 +66,10 @@ procedure Subprograms_Main is
    --  reference to the graphical canvas associated with the application window
    Canvas : Canvas_ID;
 
+   --  TODO: Remove once function is referenced
+   pragma Warnings (Off, "function ""Compute_X"" is not referenced");
    --  implement a function to compute the X coordinate
    --  x of the reference + distance * cos(angle)
-   function Compute_X
-     (Body_To_Move : Body_T;
-      Turns_Around : Body_T) return Float;
-
    function Compute_X
      (Body_To_Move : Body_T;
       Turns_Around : Body_T) return Float
@@ -80,15 +80,14 @@ procedure Subprograms_Main is
 
    --  implement a function to compute the Y coordinate
    --  y of the reference + distance * sin(angle)
-   function Compute_Y
-     (Body_To_Move : Body_T;
-      Turns_Around : Body_T) return Float;
-
 
    --  move a given body over one time step
-   procedure Move
-     (Bodies : in out Bodies_Array_T; Body_To_Move_Index : Bodies_Enum_T);
 
+   procedure Move
+     (Bodies : in out Bodies_Array_T; Body_To_Move_Index : Bodies_Enum_T) is
+   begin
+      null;
+   end Move;
 
    --  procedure Draw_Body takes 2 parameters of your choice:
    --    it needs something to draw, and something to draw it on

src/070_subprograms/template/subprograms_main.adb

@@ -25,6 +25,10 @@ with Mage.Event;    use Mage.Event;
 with Float_Maths;   use Float_Maths;
 
 procedure Subprograms_Main is
+   --$ begin question
+   --  TODO: Remove once subprograms are implemented
+   pragma Warnings (Off, "not referenced");
+   --$ end question
 
    --  define type Bodies_Enum_T and Rotating_Bodies_T
    type Bodies_Enum_T is (Sun, Earth, Moon, Satellite, Comet);
@@ -64,12 +68,12 @@ procedure Subprograms_Main is
    --  reference to the graphical canvas associated with the application window
    Canvas : Canvas_ID;
 
+   --$ begin question
+   --  TODO: Remove once function is referenced
+   pragma Warnings (Off, "function ""Compute_X"" is not referenced");
+   --$ end question
    --  implement a function to compute the X coordinate
    --  x of the reference + distance * cos(angle)
-   function Compute_X
-     (Body_To_Move : Body_T;
-      Turns_Around : Body_T) return Float;
-
    function Compute_X
      (Body_To_Move : Body_T;
       Turns_Around : Body_T) return Float
@@ -83,9 +87,6 @@ procedure Subprograms_Main is
 
    --  implement a function to compute the Y coordinate
    --  y of the reference + distance * sin(angle)
-   function Compute_Y
-     (Body_To_Move : Body_T;
-      Turns_Around : Body_T) return Float;
 
    --$ begin answer
    function Compute_Y
@@ -95,35 +96,35 @@ procedure Subprograms_Main is
    begin
       return Turns_Around.Y + Body_To_Move.Distance * Sin (Body_To_Move.Angle);
    end Compute_Y;
-   --$ end answer
 
+   --$ end answer
    --  move a given body over one time step
-   procedure Move
-     (Bodies : in out Bodies_Array_T; Body_To_Move_Index : Bodies_Enum_T);
 
-   --$ begin answer
    procedure Move
      (Bodies : in out Bodies_Array_T; Body_To_Move_Index : Bodies_Enum_T) is
+      --$ begin answer
       Body_To_Move : Body_T renames Bodies (Body_To_Move_Index);
       Turns_Around : constant Body_T := Bodies (Body_To_Move.Turns_Around);
+      --$ end answer
    begin
+      --$ line question
+      null;
+      --$ begin answer
       Body_To_Move.X :=
         Compute_X (Body_To_Move, Turns_Around);
 
       Body_To_Move.Y :=
         Compute_Y (Body_To_Move, Turns_Around);
 
       Body_To_Move.Angle := Body_To_Move.Angle + Body_To_Move.Speed;
+      --$ end answer
    end Move;
-   --$ end answer
 
    --$ begin question
    --  procedure Draw_Body takes 2 parameters of your choice:
    --    it needs something to draw, and something to draw it on
    --$ end question
    --$ begin answer
-   procedure Draw_Body (Object : Body_T; Canvas : Canvas_ID);
-
    procedure Draw_Body (Object : Body_T; Canvas : Canvas_ID) is
    begin
       Draw_Sphere

src/230_interfacing_with_c/src/solar_system.adb

@@ -20,6 +20,9 @@
 
 package body Solar_System is
 
+   --  TODO: Remove once subprograms are implemented
+   pragma Warnings (Off, "not referenced");
+
    function Get_Body
      (B      : Bodies_Enum_T;
       Bodies : access Bodies_Array_T) return Body_Access_T

src/230_interfacing_with_c/template/solar_system.adb

@@ -19,6 +19,11 @@
 -----------------------------------------------------------------------
 
 package body Solar_System is
+   --$ begin question
+
+   --  TODO: Remove once subprograms are implemented
+   pragma Warnings (Off, "not referenced");
+   --$ end question
 
    function Get_Body
      (B      : Bodies_Enum_T;

src/adv_270_subprogram_contracts/common/solar_system-graphics.adb

@@ -36,7 +36,6 @@ package body Solar_System.Graphics is
             Draw_Body (Obj, Canvas);
          end if;
       end loop;
-
    end Draw_All;
 
 end Solar_System.Graphics;