Merge branch 'mr/xfail_test' into 'edge'

Xfail a test and fix .gpr loading for the GPR server See merge request eng/ide/ada_language_server!1604
AdaCore · Jul 3, 2024 · e21aea7 · e21aea7
2 parents b36dad1 + 2d1c7f2
commit e21aea7
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 8 deletions.
diff --git a/source/gpr/lsp-gpr_documents.adb b/source/gpr/lsp-gpr_documents.adb
@@ -185,8 +185,9 @@ package body LSP.GPR_Documents is
       Self.Tree.Unload;
 
       declare
-         Opts    : GPR2.Options.Object;
-         Success : Boolean;
+         Opts       : GPR2.Options.Object;
+         Success    : Boolean;
+         Update_Log : GPR2.Log.Object;
       begin
          Opts.Add_Switch (GPR2.Options.P, String (Self.File.Value));
 
@@ -198,16 +199,29 @@ package body LSP.GPR_Documents is
              Environment      => LSP.GPR_Files.Environment);
 
          if Success then
-            Success := Self.Tree.Set_Context (Configuration.Context);
+            Self.Tree.Update_Sources (Update_Log);
+            if Update_Log.Has_Error then
+               Self.Has_Messages := True;
+            else
+               Success := Self.Tree.Set_Context (Configuration.Context);
+            end if;
          end if;
 
          if not Success then
-            for C in Self.Tree.Log_Messages.Iterate loop
-               Self.Tracer.Trace (C.Element.Format);
-               Self.Messages.Append (C.Element);
-            end loop;
             Self.Has_Messages := True;
          end if;
+
+         --  Collect all messages coming from Load...
+         for C in Self.Tree.Log_Messages.Iterate loop
+            Self.Tracer.Trace (C.Element.Format);
+            Self.Messages.Append (C.Element);
+         end loop;
+
+         --  ... and all messages coming from Update_Sources
+         for C in Update_Log.Iterate loop
+            Self.Tracer.Trace (C.Element.Format);
+            Self.Messages.Append (C.Element);
+         end loop;
       end;
 
       Update_Diagnostics;

diff --git a/testsuite/ada_lsp/C825-005.xrefs.extending/test.yaml b/testsuite/ada_lsp/C825-005.xrefs.extending/test.yaml
@@ -1,6 +1,6 @@
 title: 'C825-005.xrefs.extending'
 
 # This test needs a change of behaviour in gpr2,
-# see https://gitlab.adacore-it.com/eng/gpr/gpr-issues/-/issues/328
+# see eng/gpr/gpr-issues#328
 skip:
     - ['XFAIL', 'True']
diff --git a/testsuite/ada_lsp/F131-024.xrefs.separate_body/test.yaml b/testsuite/ada_lsp/F131-024.xrefs.separate_body/test.yaml
@@ -1 +1,6 @@
 title: 'F131-024.xrefs.separate_body'
+
+# This test is expected to fail until eng/libadalang/libadalang#1409
+# is fixed.
+skip:
+    - ['XFAIL', 'True']