Merge branch 'topic/1248-fix-external-tools-package-documentation' in…

…to 'master' Fix external tools package documentation missing See merge request eng/ide/ada_language_server!1497
AdaCore · Feb 27, 2024 · a5e57f0 · a5e57f0
2 parents 1507e1b + 7088753
commit a5e57f0
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/source/gpr/lsp-gpr_external_tools.adb b/source/gpr/lsp-gpr_external_tools.adb
@@ -203,7 +203,7 @@ package body LSP.GPR_External_Tools is
       if not Exists (Name) then
          Add (Name, Projects);
       end if;
-      if Get_Package_Description (Name)'Length > 0
+      if Get_Package_Description (Name)'Length = 0
         and then Description'Length > 0
       then
          Set_Package_Description (Name, Description);

diff --git a/testsuite/gpr_lsp/completion_package_resolve/test.json b/testsuite/gpr_lsp/completion_package_resolve/test.json
@@ -578,6 +578,34 @@
         }
       ]
     }
+  },
+   {
+    "send": {
+      "request": {
+        "id": 13,
+        "method": "completionItem/resolve",
+        "params": {
+          "label": "Ide",
+          "insertTextFormat": 1,
+          "data": [
+            "Ide"
+          ]
+        }
+      },
+      "wait": [
+        {
+          "id": 13,
+          "result": {
+            "label": "Ide",
+            "documentation": "This package specifies the options used by 'gnatstudio' IDE.",
+            "insertTextFormat": 1,
+            "data": [
+              "Ide"
+            ]
+          }
+        }
+      ]
+    }
   },
   {
     "stop": {