Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trang and Shelan- VideoStore #10

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Conversation

sheland
Copy link

@sheland sheland commented Dec 21, 2018

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C10/VideoStoreConsumer-API#8
For each person in your pair, describe something you learned from your partner during this project Trang: From Shelan, I learned the importance of planning and drafting up wireframes before beginning a project. We were able to quickly create the library, customer, and check-out rental components because we had a clear plan. It took us a little longer with the search component because we did not spend the time to plan out the nested components within it. Shelan: From Trang, I've gained a greater understanding of how components pass callbacks and keeping track where data goes. I also gained improved debugging skills by seeing my partner investigate errors by understanding how/where/why it occurred in the first place.
What was one area of React you gained more clarity on during this assignment? We've gained greater understanding of how each other's code work and how they connect with one another. We also learned a new technology, react-router.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We used the external id from the movie database to uniquely identify them.
Describe how you handled rentals with React We created event handlers that finds a customer, a movie which sets the states to with their ids then we that to make a post request to rental.
Describe a DOM event your application handled When a user clicks the library button, a list of movies from our rails api appears.
Did you use any functional stateless components? What for? We used many functional stateless components, for example, the Movie, CurrentRental and Customer components are stateless because their only functionality was to display a list of movies/rental/customers
Did you use any container components? What for? Yes, we used App and MovieSearchBar since it managed the creation and presentation of data and most of the states resided in these components
Do you have any recommendations on how we could improve this project for the next cohort? More information on deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants