testing not finished........ #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MediaRanker RevistedWhat We're Looking For
|
dHelmgren
reviewed
Nov 6, 2018
| <%= link_to "Log out, #{@current_user.handle}", logout_path, method: :delete, class: "btn btn-primary" %> </li> | ||
| <li class="nav-item app-header__nav_item"> <%= link_to "My account", user_path(session[:user_id]), class: "btn btn-primary" %> </li> | ||
| <% else %> | ||
| <%= link_to "Log In", auth_callback_path, class: "btn btn-primary" %> </li> |
There was a problem hiding this comment.
auth_callback_path is not what you use to access the site, it's what the site uses to get back to you about the request. You want something more like <%= link_to "Login with Github", "/auth/github" %>
| @@ -1,3 +1,5 @@ | |||
| <% if logged_in? %> | |||
There was a problem hiding this comment.
It would be much more efficient to use a controller filter to redirect those who aren't logged in. This is not very DRY as a solution.
| let(:user) { users(:kari) } | ||
|
|
||
| it 'logs a user out' do | ||
| perform_login(user) |
There was a problem hiding this comment.
what happens if you try to log out when nobody is logged in?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing not finished, oauth not working correctly