forked from AdaGold/media-ranker-revisited
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Karis - Edges - MedaRanker-revisited #39
Open
kimj42
wants to merge
20
commits into
Ada-C10:master
Choose a base branch
from
kimj42:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
69a3836
created test to check valid data for works#create
kimj42 6f08914
created test for invalid category and invalid title for works#create
kimj42 d2394b7
added test for bad work id
kimj42 b11b974
created test that renders 404 for bad work id
kimj42 db0cf32
tested for successful work id work#destroy
kimj42 d866137
added test for bad work id for work#destroy
kimj42 408b3d3
passed test for work index
kimj42 486b6cc
created tests for works#update
kimj42 cb82cf7
added OAuth
kimj42 deec37d
added omniauth and added 2 test for works#update
kimj42 e1e278f
filled out all tests for works controller. finished all tests for use…
kimj42 bc0f42c
added tests for sessions#create, #destroy, n passed those tests
kimj42 21d90ae
added more testing to session controller. some not passing but commen…
kimj42 c5b8009
working on sessions tests
kimj42 a7c600c
fixed one error in user test
kimj42 d40453e
fixed provider and uid null error for vote, work model
kimj42 01ba490
passed all session controller tests
kimj42 d648a77
added basic authentication
kimj42 b845823
added testing for guest users when trying access different pages
kimj42 1ecfebb
refactored tests to have a logged in user and guests
kimj42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,3 +15,5 @@ | |
|
||
# Ignore Byebug command history file. | ||
.byebug_history | ||
|
||
.env |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
# config/initializers/omniauth.rb | ||
Rails.application.config.middleware.use OmniAuth::Builder do | ||
provider :github, ENV["GITHUB_CLIENT_ID"], ENV["GITHUB_CLIENT_SECRET"], scope: "user:email" | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,15 @@ | ||
Rails.application.routes.draw do | ||
# For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html | ||
root 'works#root' | ||
get '/login', to: 'sessions#login_form', as: 'login' | ||
post '/login', to: 'sessions#login' | ||
post '/logout', to: 'sessions#logout', as: 'logout' | ||
# get '/login', to: 'sessions#login_form', as: 'login' | ||
# post '/login', to: 'sessions#login' | ||
# post '/logout', to: 'sessions#logout', as: 'logout' | ||
|
||
resources :works | ||
post '/works/:id/upvote', to: 'works#upvote', as: 'upvote' | ||
|
||
resources :users, only: [:index, :show] | ||
|
||
get "/auth/:provider/callback", to: "sessions#login", as: "login" | ||
delete "/logout", to: "sessions#logout", as: "logout" | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
class AddOauthToUser < ActiveRecord::Migration[5.2] | ||
def change | ||
add_column :users, :email, :string | ||
add_column :users, :uid, :integer, null: false | ||
add_column :users, :provider, :string, null: false | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
class AddNameToUser < ActiveRecord::Migration[5.2] | ||
def change | ||
add_column :users, :name, :string | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love that you made this a controller filter. However, you've got the same helper method in both the works and users controllers - could you put this in the application controller to help DRY it up further?