forked from AdaGold/media-ranker-revisited
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Christina MedRanRev #38
Open
Peacegypsy
wants to merge
6
commits into
Ada-C10:master
Choose a base branch
from
Peacegypsy:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,3 +15,5 @@ | |
|
||
# Ignore Byebug command history file. | ||
.byebug_history | ||
|
||
.env |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,34 +1,59 @@ | ||
class SessionsController < ApplicationController | ||
def login_form | ||
end | ||
def create | ||
auth_hash = request.env['omniauth.auth'] | ||
|
||
user = User.find_by(uid: auth_hash[:uid], provider: 'github') | ||
if user | ||
# User was found in the database | ||
flash[:success] = "Logged in as returning user #{user.name}" | ||
|
||
def login | ||
username = params[:username] | ||
if username and user = User.find_by(username: username) | ||
session[:user_id] = user.id | ||
flash[:status] = :success | ||
flash[:result_text] = "Successfully logged in as existing user #{user.username}" | ||
else | ||
user = User.new(username: username) | ||
# User doesn't match anything in the DB | ||
# Attempt to create a new user | ||
user = User.build_from_github(auth_hash) | ||
|
||
if user.save | ||
session[:user_id] = user.id | ||
flash[:status] = :success | ||
flash[:result_text] = "Successfully created new user #{user.username} with ID #{user.id}" | ||
flash[:success] = "Logged in as new user #{user.name}" | ||
|
||
else | ||
flash.now[:status] = :failure | ||
flash.now[:result_text] = "Could not log in" | ||
flash.now[:messages] = user.errors.messages | ||
render "login_form", status: :bad_request | ||
# Couldn't save the user for some reason. If we | ||
# hit this it probably means there's a bug with the | ||
# way we've configured GitHub. Our strategy will | ||
# be to display error messages to make future | ||
# debugging easier. | ||
flash[:error] = "Could not create new user account: #{user.errors.messages}" | ||
redirect_to root_path | ||
return | ||
end | ||
end | ||
redirect_to root_path | ||
end | ||
# def login | ||
# username = params[:username] | ||
# if username and user = User.find_by(username: username) | ||
# session[:user_id] = user.id | ||
# flash[:status] = :success | ||
# flash[:result_text] = "Successfully logged in as existing user #{user.username}" | ||
# else | ||
# user = User.new(username: username) | ||
# if user.save | ||
# session[:user_id] = user.id | ||
# flash[:status] = :success | ||
# flash[:result_text] = "Successfully created new user #{user.username} with ID #{user.id}" | ||
# else | ||
# flash.now[:status] = :failure | ||
# flash.now[:result_text] = "Could not log in" | ||
# flash.now[:messages] = user.errors.messages | ||
# render "login_form", status: :bad_request | ||
# return | ||
# end | ||
# end | ||
# redirect_to root_path | ||
# end | ||
|
||
def logout | ||
session[:user_id] = nil | ||
flash[:status] = :success | ||
flash[:result_text] = "Successfully logged out" | ||
redirect_to root_path | ||
# def logout | ||
# session[:user_id] = nil | ||
# flash[:status] = :success | ||
# flash[:result_text] = "Successfully logged out" | ||
# redirect_to root_path | ||
# end | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
<%= render partial: 'form', locals: {action_name: 'Edit a passenger', button_title: 'Update'} %> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Rails.application.config.middleware.use OmniAuth::Builder do | ||
provider :github, ENV["GITHUB_CLIENT_ID"], ENV["GITHUB_CLIENT_SECRET"], scope: "user:email" | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,14 @@ | ||
Rails.application.routes.draw do | ||
# For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html | ||
root 'works#root' | ||
get "/auth/:provider/callback", to: "sessions#create", as: 'auth_callback' | ||
get '/login', to: 'sessions#login_form', as: 'login' | ||
post '/login', to: 'sessions#login' | ||
post '/logout', to: 'sessions#logout', as: 'logout' | ||
|
||
# post '/logout', to: 'sessions#logout', as: 'logout' | ||
delete "/logout", to: "sessions#destroy", as: "logout" | ||
resources :works | ||
post '/works/:id/upvote', to: 'works#upvote', as: 'upvote' | ||
|
||
get '/votes/new', to: 'votes#new' | ||
post '/votes', to: 'votes#create' | ||
resources :users, only: [:index, :show] | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
class ChangeColumnNameToNickname < ActiveRecord::Migration[5.2] | ||
def change | ||
rename_column :users, :username, :nickname | ||
end | ||
end |
5 changes: 5 additions & 0 deletions
5
db/migrate/20181016215622_change_column_name_back_to_users.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
class ChangeColumnNameBackToUsers < ActiveRecord::Migration[5.2] | ||
def change | ||
rename_column :users, :nickname, :username | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
class AddColumntoUsers < ActiveRecord::Migration[5.2] | ||
def change | ||
add_column :users, :uid, :integer | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
class AddProviderColumnToUsers < ActiveRecord::Migration[5.2] | ||
def change | ||
add_column :users, :provider, :string | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
class AddPnameColumnToUsers < ActiveRecord::Migration[5.2] | ||
def change | ||
add_column :users, :name, :string | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
class AddEmailToUsers < ActiveRecord::Migration[5.2] | ||
def change | ||
add_column :users, :email, :string | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
<%= render partial: 'form', locals: {action_name: 'Edit a passenger', button_title: 'Update'} %> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't seem to be setting
session[:user_id] = user.id
here?