Amanda - Media Ranker Revisited #36

amandaungco · 2018-10-30T16:03:30Z

No description provided.

CheezItMan · 2018-10-31T03:26:03Z

MediaRanker Revisted

Feature	Feedback
General
Appropriate Tests on WorksController	The tests for `upvote` are empty and you have no tests which involve guest users and authenticated users!.
Appropriate Tests on SessionsController	NO TESTING
Appropriate Tests on UsersController	NO TESTING
Completed OAuth	INCOMPLETE
Overall	I'll be frank, this is pretty disappointing, You didn't include the Gem or the .env data to run OAuth, and your testing was sparse. I would very much like you to go the extra mile in Api-Muncher and have OAuth working on it, just to verify you are able to do it. It will be your last chance at Ada to build a Rails app that could do so.

CheezItMan · 2018-10-31T03:14:26Z

test/controllers/works_controller_test.rb

      # Precondition: there is at least one media in two of the categories

    end

    it "succeeds with no media" do
+      works.each do |work|


This could also be done with Work.destroy_all

all test pass until upvote

cb06085

CheezItMan reviewed Oct 31, 2018

View reviewed changes