Melissa : Edges : MediaRanker- Revisited #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MediaRanker RevistedWhat We're Looking For
|
droberts-sea
reviewed
Nov 5, 2018
| user = User.new(username: username) | ||
| # User doesn't match anything in the DB | ||
| # TODO: Attempt to create a new user | ||
| user = User.build_from_github(auth_hash) |
|
|
||
| it "can successfully log in with github as an existing user" do | ||
| # Arrange | ||
| # make sure that for some existing user, everything is configured! |
There was a problem hiding this comment.
There are some cases missing here. What if it's a new user, or you don't get enough information to make the account?
|
|
||
| movie = works(:movie) | ||
| id = movie.id | ||
| get work_path(id) |
There was a problem hiding this comment.
Why not Work.destroy_all? Both simpler, and less dependent on the specific data in your fixtures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.